Add config option to use local video paths in gamelist.xml export#3082
Merged
gantoine merged 5 commits intorommapp:masterfrom Mar 8, 2026
Merged
Conversation
…tead of YouTube Bump joserfc from 1.3.5 to 1.6.3
Greptile SummaryThis PR modifies Key issue:
Positive aspects:
Confidence Score: 2/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["_create_game_element(rom)"] --> B{ss_metadata\nvideo_path?}
B -- yes --> C["video = FRONTEND_RESOURCES_PATH/ss_metadata.video_path"]
B -- no --> D{gamelist_metadata\nvideo_path?}
D -- yes --> E["video = FRONTEND_RESOURCES_PATH/gamelist_metadata.video_path"]
D -- no --> F{youtube_video_id?}
F -- yes --> G["video = YOUTUBE_BASE_URL/embed/youtube_video_id"]
F -- no --> H["No video element added"]
style B fill:#f9a,stroke:#c33
style D fill:#f9a,stroke:#c33
note1["⚠️ Config flag\n(gamelist.export.local_video)\ndescribed in PR\nbut NOT implemented"]
note1 -.-> B
Last reviewed commit: fcf015e |
…event it being called on each loop
gantoine
approved these changes
Mar 8, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to #3069
Description
Add config value to use local videos in the gamelist.xml export, instead of YouTube, if set to true.
In the config, i created it as a new config array, to add some future proofing, rather than a standalone key, since gamelist is relevantly new, so config settings for the export or import can have a place to live:
Uses the same logic as here, to decide which video to use:
romm/frontend/src/composables/useGameAnimation.ts
Lines 195 to 202 in 527a45d
Checklist
Please check all that apply.