Add more plateforms to cover styles#3098
Conversation
Greptile SummaryThis PR extends the existing platform cover-style aspect-ratio system introduced in #3060 by adding more platform slugs to the existing sets and introducing a new
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
slug["Platform slug (lowercase)"]
slug --> dvd{"DVD_PLATFORMS?\ndvd-player, ps2, ngc, wii,\nwiiu, xbox, xbox360, win"}
slug --> blu{"BLU_RAY_PLATFORMS?\nblu-ray-player, ps3, ps4, ps5,\npsvita, xboxone, series-x-s"}
slug --> ds{"DS_3DS_PLATFORMS?\nnds, nintendo-dsi, 3ds,\nnew-nintendo-3ds"}
slug --> psp{"PSP_PLATFORMS?\npsp, psp-minis"}
slug --> sw{"SWITCH_PLATFORMS?\nswitch, switch-2"}
dvd -->|yes| dvdOpt["Add: 0.71/1 (DVD)"]
blu -->|yes| bluOpt["Add: 0.79/1 (Blu-ray Full)\n0.87/1 (Blu-ray Plastic)"]
ds -->|yes| dsOpt["Add: 1.08/1 (DS/3DS)"]
psp -->|yes| pspOpt["Add: 0.58/1 (PSP)"]
sw -->|yes| swOpt["Add: 0.62/1 (Switch)"]
dvdOpt --> base
bluOpt --> base
dsOpt --> base
pspOpt --> base
swOpt --> base
base["Base options always included:\n2/3 (SteamGridDB)\n3/4 (IGDB/MobyGames)\n1/1 (Squared)\n16/11 (Horizontal)"]
base --> result["aspectRatioOptions array\n(displayed in cover-style picker)"]
Last reviewed commit: 9e529ca |
| "ps3", | ||
| "ps4", | ||
| "ps5", | ||
| "psvita", |
There was a problem hiding this comment.
PSVita uses proprietary game cards, not Blu-ray
psvita is added to BLU_RAY_PLATFORMS, but the PS Vita uses its own proprietary game card format — not Blu-ray discs. The physical game case dimensions for PS Vita (~84 mm × 104 mm ≈ 0.808/1) are indeed close to the Blu-ray "Full artwork" ratio (0.79/1), so grouping them may be a pragmatic choice rather than a strict categorization.
That said, it might be worth adding a dedicated PSVita aspect ratio option (e.g., 0.81 / 1) with a source label like "PS Vita" — both for accuracy and so that users can see a label that matches their platform, similar to how PSP has its own dedicated entry. This is a suggestion rather than a hard bug, since the two ratios are close enough that it may not matter visually.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
gantoine
left a comment
There was a problem hiding this comment.
Looks good!
I wanted each platform to be able to choose whichever style fits best.
Your original PR made perfect sense, but this approach should/will allow us to add as many custom ratios as we want without crowding the list in the UI.
Description
Thanks for merging #3060.
My initial plan wasn’t to show the new cover only on specific platforms. I wanted each platform to be able to choose whichever style fits best. However, the current approach also works, and I understand that having fewer options can make the implementation cleaner.
In this PR, I’ve added support for a few more platforms so they work with the same system as well.
Checklist