Skip to content

feat: show TheGamesDB link on platform drawer when tgdb_id is set#3254

Merged
gantoine merged 2 commits intomasterfrom
romm-3251
Apr 12, 2026
Merged

feat: show TheGamesDB link on platform drawer when tgdb_id is set#3254
gantoine merged 2 commits intomasterfrom
romm-3251

Conversation

@gantoine
Copy link
Copy Markdown
Member

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #3251

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 12, 2026 23:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for displaying a TheGamesDB (TGDB) link in the platform info drawer when a platform has tgdb_id set, aligning behavior with other metadata providers and addressing issue #3251.

Changes:

  • Add a TGDB chip/link to PlatformInfoDrawer.vue when currentPlatform.tgdb_id is present.
  • Populate tgdb_id during platform scanning using the TGDB metadata handler as an additional fallback.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
frontend/src/components/Gallery/AppBar/Platform/PlatformInfoDrawer.vue Adds TGDB external link chip in the platform drawer UI when tgdb_id exists.
backend/handler/scan_handler.py Extends scan_platform to fill tgdb_id from TGDB handler when other sources don’t provide it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 203 to 207
"ra_id": ra_platform.get("ra_id") or hasheous_platform.get("ra_id") or None,
"tgdb_id": moby_platform.get("tgdb_id")
or hasheous_platform.get("tgdb_id")
or tgdb_platform.get("tgdb_id")
or None,
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a new fallback for tgdb_id coming directly from the TGDB metadata handler. There is existing test coverage for scan_platform, but it currently doesn't assert tgdb_id; please extend/add a test case to verify tgdb_id is populated when TGDB provides it (e.g., for n64) and other sources don't override it.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 12, 2026

Test Results (mariadb)

1 243 tests  ±0   1 243 ✅ ±0   3m 48s ⏱️ -17s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 154165f. ± Comparison against base commit fe4d78a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 12, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
16037 10895 68% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/handler/scan_handler.py 57% 🟢
TOTAL 57% 🟢

updated for commit: 154165f by action🐍

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 12, 2026

Test Results (postgresql)

1 243 tests  ±0   1 243 ✅ ±0   3m 47s ⏱️ -14s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 154165f. ± Comparison against base commit fe4d78a.

♻️ This comment has been updated with latest results.

@gantoine gantoine merged commit 3388b34 into master Apr 12, 2026
13 checks passed
@gantoine gantoine deleted the romm-3251 branch April 12, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Link to TheGamesDB not displayed in the Platform drawer

2 participants