Prefer ROM's own region tag for ScreenScraper and IGDB artwork

[gantoine]

Summary

• ScreenScraper and IGDB now check the ROM's filename region tag (e.g. (Europe)) before falling back to scan.priority.region when picking artwork and localized titles. Previously, a US-first config would force US covers onto European ROMs even when an EU asset existed.
• Adds a shared REGION_NAME_TO_PROVIDER_SHORTCODE map ("Europe"→"eu", etc.) so the ROM's parsed region names line up with what providers expect.
• Threads the Rom through IGDB's get_rom, get_rom_by_id, get_matched_rom_by_id, and get_matched_roms_by_name so they can consult its regions; signatures now match the ScreenScraper handler (rom first, required).

Test plan

• Scan a library with mixed region tags (e.g. Game (Europe).rom, Game (Japan).rom) and confirm SS pulls EU/JP covers per the tag while config priority still governs untagged ROMs

Screenshots

[github-actions]

Test Results (mariadb)

    1 files      1 suites   4m 21s ⏱️
1 320 tests 1 320 ✅ 0 💤 0 ❌
1 322 runs  1 322 ✅ 0 💤 0 ❌

Results for commit 8e009df.

♻️ This comment has been updated with latest results.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
16317	11331	69%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
backend/endpoints/roms/_init_.py	63%	🟢
backend/endpoints/search.py	29%	🟢
backend/handler/filesystem/base_handler.py	90%	🟢
backend/handler/metadata/igdb_handler.py	36%	🟢
backend/handler/metadata/ss_handler.py	39%	🟢
backend/handler/scan_handler.py	56%	🟢
TOTAL	52%	🟢

updated for commit: 8e009df by action🐍

[github-actions]

Test Results (postgresql)

    1 files      1 suites   4m 8s ⏱️
1 320 tests 1 320 ✅ 0 💤 0 ❌
1 322 runs  1 322 ✅ 0 💤 0 ❌

Results for commit 8e009df.

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

Updates metadata selection so ScreenScraper and IGDB prefer a ROM’s own parsed filename region tags (e.g. (Europe)) before falling back to scan.priority.region, preventing config-first region priority from forcing mismatched artwork/localized titles.

Changes:

• Add REGION_NAME_TO_PROVIDER_SHORTCODE mapping and use it to translate ROM region names into provider region codes.
• Update ScreenScraper region preference logic to prepend ROM-tag-derived regions.
• Thread Rom through IGDB handler lookup methods so IGDB locale/artwork selection can prefer ROM-tag regions.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
backend/tests/handler/metadata/test_ss_handler.py	Adjusts test ROM factory to support rom.regions.
backend/handler/scan_handler.py	Updates IGDB scan calls to pass rom into the IGDB handler.
backend/handler/metadata/ss_handler.py	Prepends ROM-tag-derived regions to ScreenScraper region preference order.
backend/handler/metadata/igdb_handler.py	Prefers ROM-tag-derived region when choosing IGDB localization/cover.
backend/handler/filesystem/base_handler.py	Introduces shared region-name → provider-shortcode mapping.
backend/endpoints/search.py	Passes rom into IGDB search/match methods.
backend/endpoints/roms/init.py	Passes rom into IGDB lookup when updating a ROM’s IGDB metadata.

Comments suppressed due to low confidence (1)

backend/handler/metadata/ss_handler.py:45

• REGION_NAME_TO_PROVIDER_SHORTCODE lookup is case-sensitive, but Rom.regions comes from filename tag parsing (FSRomsHandler.parse_tags) which preserves the raw tag text. If a ROM tag is (europe) / mixed-case, the mapping will miss and the ROM’s region won’t actually be preferred. Normalize region_name (e.g., casefold()/title()) or change the mapping to use lowercase keys and look up with casefold().

    if rom is not None and isinstance(rom.regions, list):
        for region_name in rom.regions:
            code = REGION_NAME_TO_PROVIDER_SHORTCODE.get(region_name)
            if code:
                rom_codes.append(code)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.