Add comma-separated metadata attribute support to gamelist#3380
Merged
gantoine merged 2 commits intoMay 16, 2026
Merged
Conversation
Add comma-separated metadata attribute support to gamelist
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a helper to split comma-separated values in gamelist.xml metadata fields so that attributes like <lang>en,fr</lang> become multiple list entries instead of a single string. Applied to companies (developer + publisher merged & deduped), franchises, genres, regions, and languages.
Changes:
- New
_split_comma_separated_valueshelper that trims and compacts comma-split tokens. - Updated
extract_metadata_from_gamelist_romto split developer/publisher/family/genre and dedupe companies. - Updated
_parse_gamelist_xmlto split region and language elements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gantoine
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comma-separated metadata attribute support to gamelist
Description
Hello. I've implemented support for importing attributes as a list when the values are comma-separated and romm supports a list for that attribute.
Previously, importing an attribute like
<lang>en,fr</lang>would create a single value in romm, but now it will create two values accordingly.Which attributes this works for: