fix(screenscraper): skip name search after notgame hash lookup

[Spinnich]

Description
When jeuInfos.php returns a notgame entry (BIOS files, ZZZ hacks, unlicensed dumps, etc.), RomM had two related bugs:

1. Notgame stored as a valid match — if the entry had a real numeric ID, lookup_rom() passed it straight to build_ss_game(), storing it as a legitimate SS match.
2. Pointless name search — if the entry had a falsy ID (e.g. "0"), lookup_rom() returned SSRom(ss_id=None) and scan_handler fell through to get_rom(), issuing a jeuRecherche.php fuzzy name search that always returned nothing useful (SS's own notgame flag means no valid match will ever be found by name). This wastes the user's daily API quota.

Fix:
Bug #3415

• Adds NOTGAME_NAME_PREFIX constant and _is_notgame() helper (checks both the notgame: "true" API field and ZZZ(NOTGAME) name prefix)
• lookup_rom() now detects notgame entries before calling build_ss_game() and returns SSRom(ss_id=None, notgame=True)
• scan_handler guards the get_rom() fallback: if lookup_rom() returned notgame=True, the jeuRecherche.php call is skipped entirely
• _search_rom() now filters out notgame entries from name search results (defensive fix for the name search path)
• Adds notgame: NotRequired[bool] field to SSRom

Checklist

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

🤖 Drafted with Claude Code

[Copilot]

Pull request overview

Fixes ScreenScraper “notgame” handling during scans so BIOS/“ZZZ(NOTGAME)” entries do not get treated as valid matches and do not trigger the fallback fuzzy name search (saving API quota).

Changes:

• Add _is_not_game() detection and use it to ignore notgame responses from both hash lookup and name search results.
• Change SSHandler.lookup_rom() to return (SSRom, is_not_game) and update scan flow to skip the filename-search fallback when is_not_game is true.
• Add unit tests covering lookup_rom() returning the notgame flag.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
backend/handler/metadata/ss_handler.py	Adds notgame detection, filters notgame results, and returns an explicit notgame indicator from hash lookup.
backend/handler/scan_handler.py	Skips ScreenScraper name-search fallback when hash lookup indicates a notgame match.
backend/tests/handler/metadata/test_ss_handler.py	Updates notgame helper tests and adds new async tests for lookup_rom notgame signaling.

Comments suppressed due to low confidence (2)

backend/tests/handler/metadata/test_ss_handler.py:365

• ScreenScraperService.get_game_info is an async method, but these tests patch it with patch.object(..., return_value=...), which replaces it with a non-awaitable MagicMock. Since lookup_rom() does await self.ss_service.get_game_info(...), this will raise TypeError: object dict can't be used in 'await'. Patch with new_callable=AsyncMock (or set the attribute to an AsyncMock(return_value=...)) so the awaited call works.

        assert result == url

    def test_does_not_duplicate_existing_credentials(self):
        """Pre-existing ssid/sspassword on the URL are replaced, not duplicated."""

backend/tests/handler/metadata/test_ss_handler.py:382

• Same issue as above: get_game_info is awaited inside lookup_rom(), but it is patched with a plain MagicMock via patch.object(..., return_value=...). Use AsyncMock so the awaited call returns notgame_response without raising a TypeError.

    def test_handles_stripped_url_from_extract_media(self):
        """A URL that's already had ssid/sspassword stripped (the storage form)
        gets credentials re-attached cleanly, with dev creds and other params
        left intact."""

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.