Add iOS pseudo-fullscreen shim for EmulatorJS player#3431
Merged
Conversation
Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix fullscreen emulation issue on iOS
Add iOS pseudo-fullscreen shim for EmulatorJS player
May 25, 2026
gantoine
approved these changes
May 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an iOS-only pseudo-fullscreen shim for the EmulatorJS player so fullscreen requests can work on iOS Safari while preserving existing fullscreen event flows.
Changes:
- Adds iOS/iPadOS detection and fullscreen API overrides scoped to EmulatorJS setup.
- Applies pseudo-fullscreen styling and hides Vuetify navigation chrome while active.
- Installs the shim before EmulatorJS loader initialization and cleans it up on failures/unmount.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend/src/views/Player/EmulatorJS/utils.ts |
Adds iOS fullscreen shim utilities, fullscreen API overrides, pseudo-fullscreen styles, event dispatching, and cleanup. |
frontend/src/views/Player/EmulatorJS/Base.vue |
Installs the shim before EmulatorJS loads and removes it on loader failure or component teardown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fullscreen requests from EmulatorJS were ignored on iOS, leaving the app chrome visible and the player constrained to the normal layout. This change adds an iOS-only fullscreen shim so EmulatorJS can enter and exit a pseudo-fullscreen mode while keeping RomM's fullscreen state in sync.
iOS fullscreen shim
document.fullscreenEnabled = truerequestFullscreen,webkitRequestFullscreen, anddocument.exitFullscreenfor iOS devices onlyPseudo-fullscreen behavior
100svhsizing and a high z-index to cover the app shellRomM UI/state synchronization
.v-app-bar.v-bottom-navigation.v-navigation-drawerfullscreenchangeevents so existing fullscreen listeners continue to work without special-casing iOSLifecycle integration