implement accumulator store and proof verification#605
Merged
jolestar merged 10 commits intorooch-network:mainfrom Aug 15, 2023
Merged
implement accumulator store and proof verification#605jolestar merged 10 commits intorooch-network:mainfrom
jolestar merged 10 commits intorooch-network:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jolestar
reviewed
Aug 11, 2023
| } | ||
|
|
||
| fn save_accumulator(&self, accumulator: Accumulator) -> Result<()> { | ||
| self.get_accumulator_store().save_accumulator(accumulator) |
Contributor
There was a problem hiding this comment.
We can not directly save the whole accumulator.
Refs
Contributor
Author
There was a problem hiding this comment.
Alright.
Thank you for the refs. They'd help
Contributor
Author
There was a problem hiding this comment.
Hi, @jolestar I have added new commits.
Most part of the code reuse starcoin implementation, https://github.com/starcoinorg/starcoin/tree/master/commons/accumulator. I modified the code to fit into the moveos codebase and successfully run.
Do you think it's okay and I can proceed with changing the PR status from draft?
This reverts commit 19240f1.
bytedeveloperr
requested review from
baichuan3,
templexxx and
wow-sven
as code owners
templexxx
approved these changes
Aug 15, 2023
wubuku
added a commit
to wubuku/rooch
that referenced
this pull request
Aug 17, 2023
* commit 'e619c845f9b532430c65858ba2e0d2ff1c4b9e86': [VM] Refactor view_function result, return the VMStatus to caller (rooch-network#646) add `rooch server clean` to rooch cli (rooch-network#634) fix const typo => `EFunctionCallBeyondSessionScope` (rooch-network#645) [rooch-networkgh-641] unify coin id to u64 and refactor blockchain scheme. (rooch-network#642) [SessionKey] Check the transaction va session scope (rooch-network#640) implement accumulator store and proof verification (rooch-network#605) refine README.md (rooch-network#639) [rooch-networkgh-621] refactor algorithms and validators. (rooch-network#636) update `rooch-cli.zh-CN.mdx` and translate it (rooch-network#637) [CLI] Support session key in CLI (rooch-network#629) Auto test for module publishing in Move (rooch-network#632) typescript sdk part of issues/585 (rooch-network#597) [types] Migrate module bindings from rooch-framework to rooch-types (rooch-network#623) add weekly 2023-08-14 (rooch-network#624) Detecting global storage instructions during module publishing. (rooch-network#619) [rooch-networkgh-609] refactor validators for other schemes. (rooch-network#610) Verify and publish modules in Move (rooch-network#392) Feature owen opt client code gen (rooch-network#600) Use generic parameter placeholders. (rooch-network#614)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #412