Fix ESLint warnings for server#331
Merged
Merged
Conversation
This patch fixes 5 ESLint warnings.
The max-lines disable in actionStatistics.ts no longer suppresses any
warning and only adds noise.
In apiKey.ts, "||" is replaced with "??" for description and lastUsedAt
fallbacks. "||" coerces any falsy value (including empty string: "") to
the default, whereas "??" only fires on null/undefined - which may be
the actual intent here. An empty-string description would be silently
discarded with "||".
In integrationRegistry/index.ts and RetryFailedNcmecDecisionsJob.ts,
null-guarded assignment blocks (if (x == null) { x = ... }) are
collapsed to "??=" assignments, which is the idiomatic shorthand for
exactly that pattern and makes the intent immediately readable.
…ationResolvers The Query and Mutation objects in apiKey.ts are typed as any, which removes all type-checking on resolver arguments and the context object. The codegen pipeline already produces GQLQueryResolvers and GQLMutationResolvers with the correct signatures. Using those types means wrong argument names, missing fields, or context misuse will be caught at compile time rather than at runtime. Error names must match a GraphQL union member because gqlErrorResult uses them as type name. 'InternalServerError' is a valid CoopErrorName but not a member of the RotateApiKeyResponse or RotateWebhookSigningKeyResponse unions, so Apollo can't resolve the type.
…ute any route.get returns Route<never, ...> which is invariant with Route<any, any> in ControllerRouteList, so individual routes needed as Route<any, ...> casts. Move the cast to the routes array level using as ControllerRouteList, which is already covered by the centralized eslint-disable on the type definition.
The SAML strategy callbacks passed Sequelize model instances to
done(), which expects "Record<string, unknown>". The original code used
"as any" to fix the mismatch; simply removing those casts broke the
build because Sequelize models carry no string index signature.
Use "user.toJSON()" instead - it returns a plain object that
genuinely satisfies "Record<string, unknown>" at runtime.
For serializeUser, augment "Express.User" in decs.d.ts with the
single field it actually accesses ("id: string").
PostgresAnalyticsAdapter and ClickhouseKyselyAdapter declare their Kysely fields as Kysely<any>, which disables query-builder type- checking for every table access and column reference in those adapters. PostgresAnalyticsAdapter is parameterised with Kysely<AnalyticsSchema> and ClickhouseKyselyAdapter with Kysely<Record<string, unknown>>, so Kysely can enforce table and column existence at compile time rather than at runtime. Stub method signatures using ...args: any[] are replaced with unknown[] so that the interface contract is actually enforced on the concrete classes.
…icsSchema
RuleExecutionLogger, ReportingRuleExecutionLogger, RoutingRuleExecutionLogger,
and ContentApiLogger cast table-name strings and row arrays to any when calling
bulkWrite because those table names were not yet keys of AnalyticsSchema. The
casts silenced the errors but also prevented the compiler from catching a
misspelled or removed table name.
Adding the missing tables (REPORTING_SERVICE.REPORTING_RULE_EXECUTIONS,
MANUAL_REVIEW_TOOL.ROUTING_RULE_EXECUTIONS) to AnalyticsSchema and widening
CONTENT_API_REQUESTS to {[key:string]:unknown} makes the constraint real and
allows all call-site casts to be deleted or narrowed to their correct types.
PostgresAnalyticsAdapter.flushTable used a cast that typed rows as a union
of all schema table types. Kysely requires an intersection of required fields
across those types, which the open-ended {[key:string]:unknown} entries
(introduced in this commit) cannot satisfy. Instead, bulkWrite now stores a
pre-built, fully-typed insert closure alongside each row buffer while it
still knows the concrete table type (flushTable just calls that closure).
@opentelemetry/semantic-conventions deprecated the SEMATTRS_EXCEPTION_* identifiers in favor of ATTR_EXCEPTION_*. The two names refer to the same attribute keys, so this is a pure rename. Clears three @typescript-eslint/no-deprecated warnings.
Small, mechanical cleanups flagged by @typescript-eslint/no-unnecessary-condition and @typescript-eslint/no-unnecessary-type-assertion. Each change either removes a guard the type system has already proven redundant, or removes an assertion that doesn't change the inferred type. * routes/integration_logos/serveIntegrationLogo*.ts: typed the express sendFile callback as "(err?: Error)" and simplified "err != null" to a truthiness check. Matches express's actual contract. * routes/reporting/submitReport.ts: dropped an always-truthy "hashes &&" guard. * rule_engine/RuleEngine.ts: dropped "?? []" on a non-nullable return. * utils/sql.ts: removed two "SelectQueryBuilder<...>" casts the inference now handles cleanly.
up a FileAnnotations object one case at a time. That tripped the complexity rule (max 20) and made the mapping itself hard to audit. Replaced with a single "Record<NCMECFileAnnotationType, keyof FileAnnotations>" lookup table plus a small for-loop. The table is the single source of truth for the NCMEC-enum -> field-name correspondence, and TypeScript's exhaustiveness checking on the Record key forces every enum variant to be mapped.
Each case below previously used "any" (or "as any") to paper over a typing problem. Where a cast is still needed, it goes through the narrowest meaningful type. - condition_evaluator/conditionSet.ts: typed the working array as "Array<ReadonlyDeep<LeafConditionWithResult | ConditionSetWithResult>>" and replaced two "as any" casts with a single documented narrowing cast at the return site. The public type is a discriminated union over arrays-of-leaves vs arrays-of-sets, which can't be pushed into during the loop; runtime contents stay uniform with the input conditions. - condition_evaluator/leafCondition.ts: typed the signal-result generic as "SignalResult<SignalOutputType>", removing both an "as any" and an unnecessary "as SignalOutputType" assertion at the call time. - graphql/datasources/UserApi.ts: typed the login/signUp/logout passport glue using the generated "GQLMutation-Args" types and a small structural context type (instead of "any"). - services/apiKeyService/apiKeyService.ts: derived "ApiKeyRow" from "Selectable<ApiKeyServicePg['public.api_keys']>" (Kysely) and used it as the param type of "mapDbRecordToApiKeyRecord". - services/manualReviewToolService/modules/CommentOperations.ts: replaced "as any" / "as any[]" with "as JobId" / "as JobId[]" using the existing branded type. - services/ruleAnomalyDetectionService/getRuleAnomalyDetectionStatistics.ts: typed warehouse rows as "Record<string, unknown>" with explicit field-level casts, and the binding accumulator as "string[]". - services/ruleAnomalyDetectionService/detectRulePassRateAnomaliesJob.ts: preserved the runtime guard against missing org rows by indexing through "Partial<typeof orgsForChangedRules>". keyBy's "Record<string, T>" return type lies about lookups always succeeding. - bin/run-worker-or-job.ts: replaced "(container as any)[name]" with a typed "container[name as keyof Dependencies] as WorkerOrJob" lookup.
Three locations have "any" casts that can't be replaced today without upstream typing work that's already tracked by TODOs. - graphql/modules/insights.ts: resolver maps five times "getRulePassingContentSamples" results onto types that require "tags" and "policies" fields the datasource doesn't yet populate. The fix belongs in the datasource's typing, not in each resolver. Kept the localized "as any" cast and the existing TODO comments - graphql/resolvers.ts: same shape of pre-existing TODO on "getAllRuleInsights" return type - services/analyticsQueries/ItemHistoryQueries.ts: the data warehouse schema isn't modeled in TS, so the Kysely instance is intentionally "Kysely<any>" (so the string-based column selections pass type-check).
Tests that mock private methods or attach properties to typed services
need escape hatches that production code shouldn't. This patch replaces
"any" with real types where possible.
- condition_evaluator/conditionSet.test.ts: wrap RuleEvaluationContext /
SafeTracer mock stubs with "eslint-disable" / "eslint-enable" and a
comment.
- services/derivedFieldsService/helpers.test.ts: the test intentionally
passes invalid inputs to exercise error paths. Wrapped that block in a
paired "eslint-disable" / "eslint-enable" for "no-explicit-any" with a
comment.
- services/manualReviewToolService/modules/CommentOperations.test.ts:
replaced "as any" on job ids with "as JobId"; switched the
"(commentOps as any).getRelatedJobIds(...)" private-method probe to
bracket access ("commentOps['getRelatedJobIds'](...)"). Same access
pattern at runtime without a need for casting.
- services/orgAwareSignalExecutionService/signalExecutionService.test.ts:
extended two existing narrow "eslint-disable" directives to also cover
"no-explicit-any" for jest mock assignments. Added a paired
"eslint-disable" / "eslint-enable" block where the original
next-line directive couldn't reach the multi-line cast.
- services/ruleAnomalyDetectionService/getRuleAnomalyDetectionStatistics.test.ts:
typed the mock query's "tracer" parameter as "unknown". Kept the
unavoidable "jest.fn() as any" for the typed mock fixture and "{} as any"
for the unused tracer arg, both with narrow per-line disables that name
the rule and the reason.
- test/extendExpect.ts: replaced "(toMatchSnapshot as any).call" with
"toMatchSnapshot.call(this as SnapshotContext, ...)" using
jest-snapshot's exported "Context" type. Added an explicit return type
to satisfy "promise-function-async" (the inferred sync|async union was
tripping the rule).
Three switches dispatch on a discriminated union that today has only one variant: AggregationsService.evaluateAggregation, serializeAggregation, and the derivedFieldsService recipe-operation reducer. With one variant each case label is trivially equal to the discriminant, which trips @typescript-eslint/no-unnecessary-condition. The switches stay because they're load-bearing: when a new variant is added to the union, the existing case stops being exhaustive and the "default: assertUnreachable(...)" branch surfaces the gap at compile time.
pawiecz
force-pushed
the
fix-eslint-server
branch
from
6104272 to
7c836be
Compare
pawiecz
force-pushed
the
fix-eslint-server
branch
from
73aa227 to
6f6295d
Compare
The two SAML strategy callbacks still called `user.toJSON()` left over from the Sequelize User instance. `kyselyUserFindByEmail` now returns a plain `GraphQLUserParent` object.
The "fresh deploy" guard checked "lastTimestamp.last_insert == null",
which triggered @typescript-eslint/no-unnecessary-condition: the Kysely
schema types "last_insert" as a non-null "Date", matching the SQL
column ("NOT NULL DEFAULT '-infinity'").
This patch replaces "== null" with
"Number.isFinite(last_insert.valueOf())". This removes the dead branch
(and the lint warning) and makes the fresh-deploy path actually fall
back to "new Date(0)" as intended.
pawiecz
requested review from
cassidyjames,
dom-notion,
juanmrad,
julietshen and
vinaysrao1
as code owners
juanmrad
requested changes
May 1, 2026
Member
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (6)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughComprehensive TypeScript type safety and eslint cleanup across the server codebase. Updates OpenTelemetry exception constants, adds Express.User interface, narrows GraphQL resolver and UserAPI parameter types, refactors condition evaluation accumulation, extends analytics schema with dynamic tables, improves adapter typing, updates route controllers to use type constraints, and documents intentional any-cast escape hatches with eslint directives. ChangesAuthentication and Telemetry Modernization
GraphQL Resolver Type Safety and Error Names
Condition Evaluation Refactoring
Route Controller Typing and Callbacks
Analytics Schema Extensibility and Adapter Typing
Service Type Safety and Logic Improvements
Test Utilities and Matchers
Background Job Type Improvements
🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly Related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses ESLint warnings in the server package by tightening types (reducing any), simplifying control flow, and adding narrowly-scoped lint suppressions where intentional.
Changes:
- Replaced several
anyusages with more precise types (GraphQL resolvers, Kysely adapters/queries, tests, and utility code). - Refactored a few sections to reduce ESLint complexity/unnecessary-condition warnings (e.g., mapping tables,
??=usage, simplified guards). - Updated minor runtime logic for edge cases (e.g.,
-infinitytimestamp handling) and improved type declarations (ExpressUseraugmentation).
Reviewed changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/workers_jobs/RetryFailedNcmecDecisionsJob.ts | Uses ??= to simplify lazy org-user caching. |
| server/workers_jobs/RefreshMRTDecisionsMaterializedViewJob.ts | Handles -Infinity seed timestamp safely when computing backfill window. |
| server/utils/sql.ts | Removes casts around orderBy loop in takeLast. |
| server/utils/errors.ts | Adds new CoopError name literals for API key rotation errors. |
| server/test/extendExpect.ts | Improves matcher typing and removes any call-site. |
| server/storage/dataWarehouse/PostgresAnalyticsAdapter.ts | Tightens adapter typing and restructures pending write buffering. |
| server/storage/dataWarehouse/IDataWarehouseAnalytics.ts | Relaxes some table schemas to dynamic [key: string]: unknown and adds new table keys. |
| server/storage/dataWarehouse/ClickhouseAdapter.ts | Narrows Kysely instance typing; adds targeted lint suppression for Kysely Dialect signature. |
| server/services/ruleAnomalyDetectionService/getRuleAnomalyDetectionStatistics.ts | Replaces any result mapping with safer Record<string, unknown> casts. |
| server/services/ruleAnomalyDetectionService/getRuleAnomalyDetectionStatistics.test.ts | Replaces any tracer with unknown and adds targeted lint suppressions for test casts. |
| server/services/ruleAnomalyDetectionService/detectRulePassRateAnomaliesJob.ts | Makes index access honestly nullable via Partial<> cast. |
| server/services/orgAwareSignalExecutionService/signalExecutionService.test.ts | Consolidates eslint disables around intentional test mutations/casts. |
| server/services/ncmecService/ncmecReporting.ts | Refactors file annotation mapping to a table-driven approach to reduce complexity. |
| server/services/manualReviewToolService/modules/CommentOperations.ts | Replaces any casts with branded JobId typing in queries. |
| server/services/manualReviewToolService/modules/CommentOperations.test.ts | Uses bracket access for private method testing; updates JobId casts. |
| server/services/integrationRegistry/index.ts | Simplifies cached singleton initialization via ??=. |
| server/services/derivedFieldsService/helpers.ts | Adds rationale + narrow lint suppression for intentional exhaustive switch pattern. |
| server/services/derivedFieldsService/helpers.test.ts | Adds scoped eslint disable to allow constructing invalid inputs in tests. |
| server/services/apiKeyService/apiKeyService.ts | Introduces typed ApiKeyRow for mapping DB rows to domain records. |
| server/services/analyticsQueries/ItemHistoryQueries.ts | Documents/contains intentional any usage for unmodeled warehouse schema; removes any in result mapping. |
| server/services/analyticsLoggers/RuleExecutionLogger.ts | Narrows bulkWrite row typing to AnalyticsSchema['RULE_EXECUTIONS'][]. |
| server/services/analyticsLoggers/RoutingRuleExecutionLogger.ts | Removes unnecessary as any table name cast after schema expansion. |
| server/services/analyticsLoggers/ReportingRuleExecutionLogger.ts | Removes unnecessary as any table name cast after schema expansion. |
| server/services/analyticsLoggers/ContentApiLogger.ts | Removes unnecessary as any table name cast after schema relaxation. |
| server/services/aggregationsService/AggregationsService.ts | Adds rationale + narrow lint suppression for exhaustive switches over single-variant unions. |
| server/rule_engine/RuleEngine.ts | Simplifies enabled-rules handling now that query returns an array. |
| server/routes/user_scores/UserScoresRoutes.ts | Replaces broad assertions with satisfies Controller and ControllerRouteList. |
| server/routes/reporting/submitReport.ts | Removes redundant hashes && check before Object.keys(hashes). |
| server/routes/policies/PoliciesRoutes.ts | Replaces broad assertions with satisfies Controller and ControllerRouteList. |
| server/routes/integration_logos/serveIntegrationLogoWithBackground.ts | Tightens sendFile callback error typing/guard. |
| server/routes/integration_logos/serveIntegrationLogo.ts | Tightens sendFile callback error typing/guard. |
| server/graphql/resolvers.ts | Scopes eslint disables around known resolver typing mismatch TODO. |
| server/graphql/modules/insights.ts | Scopes eslint disables around known incomplete typing TODOs. |
| server/graphql/modules/apiKey.ts | Uses generated resolver types; improves nullish handling and uses new error names. |
| server/graphql/modules/actionStatistics.ts | Removes now-unneeded max-lines disable (file is within typical limits). |
| server/graphql/datasources/UserApi.ts | Replaces any args with generated GraphQL arg types and narrows context types. |
| server/decs.d.ts | Augments Express.User with id to avoid per-call casts in passport handlers. |
| server/condition_evaluator/leafCondition.ts | Narrows signal result generic typing and removes an outputType cast. |
| server/condition_evaluator/conditionSet.ts | Refactors condition result collection to reduce unsafe casts while preserving sequential evaluation. |
| server/condition_evaluator/conditionSet.test.ts | Scopes eslint disables around intentional any stubs. |
| server/bin/run-worker-or-job.ts | Replaces container any index with keyof Dependencies cast. |
| server/api.ts | Updates OpenTelemetry semantic convention constant names; removes unnecessary user as any casts. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
server/services/derivedFieldsService/helpers.test.ts (1)
267-316: ⚡ Quick winPrefer line-level eslint suppressions over block-level disable/enable.
The block-level
eslint-disable/eslint-enablepair spans ~50 lines but only 4 specific lines actually need the suppression (lines 272, 293, 302, 311). As per coding guidelines, use narrowly-scoped// eslint-disable-next-linecomments on each line that requires theanycast instead of disabling the rule for the entire block.♻️ Suggested refactor to line-level suppressions
Remove the block-level disable/enable:
- // The casts to "any" below intentionally bypass TS so that we can - // construct invalid inputs (the very thing parseDerivedFieldSpec is - // expected to reject at runtime). - /* eslint-disable `@typescript-eslint/no-explicit-any` */ expect(() => { parseDerivedFieldSpec( serializeDerivedFieldSpec({ source: { type: 'CONTENT_FIELD', name: 'hi', contentTypeId: '1' }, + // Intentional invalid type to test runtime validation + // eslint-disable-next-line `@typescript-eslint/no-explicit-any` -- testing runtime rejection of invalid derivationType derivationType: 'hasOwnProperty' as any, // invalid, hacking attempt. }), );Apply similar line-level suppressions to lines 293, 302, and 311, and remove the closing
eslint-enableat line 316.As per coding guidelines: Use narrowly-scoped
// eslint-disable-next-line <rule>comments with explanations instead of block-level disabling.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@server/services/derivedFieldsService/helpers.test.ts` around lines 267 - 316, The test currently uses a broad block-level eslint-disable/@typescript-eslint/no-explicit-any around multiple expectations; replace that with narrowly scoped line-level suppressions: remove the block-level /* eslint-disable ... */ and /* eslint-enable ... */ and add // eslint-disable-next-line `@typescript-eslint/no-explicit-any` immediately above each specific line where an any cast is used (the lines calling parseDerivedFieldSpec(serializeDerivedFieldSpec({... derivationType: ... as any})) and the three other casts for source with as any/typed casts), keeping the calls to parseDerivedFieldSpec and serializeDerivedFieldSpec intact and add short comments explaining why the any is needed for each suppressed line.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@server/services/manualReviewToolService/modules/CommentOperations.ts`:
- Line 34: Keep the cast on jobId when filtering
manual_review_tool.job_creations.id (i.e., keep .where('id', '=', jobId as
JobId)) but remove the redundant casts on jobIds (remove jobIds as JobId[]),
because manual_review_tool.job_comments.job_id is a plain string; pass jobIds
directly into the .where(... 'in', jobIds) calls in CommentOperations (the
places using jobIds and jobId variables).
In
`@server/services/orgAwareSignalExecutionService/signalExecutionService.test.ts`:
- Around line 33-36: Replace the block-level eslint disable/enable wrapper with
line-scoped suppressions: remove the /* eslint-disable ... */ and /*
eslint-enable ... */ block that surrounds the two assignments and instead add a
concise // eslint-disable-next-line functional/immutable-data,
`@typescript-eslint/no-explicit-any` comment immediately above the lines that set
(mockTextBankStringsLoader as any).close = jest.fn() and (mockGetImageBank as
any).close = jest.fn(); do the same for the later similar block (the one that
wraps the other mock close assignments) so each offending line has its own
narrowly-scoped eslint-disable-next-line comment preserving the short rationale.
In `@server/storage/dataWarehouse/PostgresAnalyticsAdapter.ts`:
- Line 14: The PostgresAnalyticsAdapter currently imports and types against
Kysely (symbols: sql, InsertObject, Kysely) and must be converted to use Knex
per the server standard: remove Kysely imports, add/import the Knex client type,
replace any Kysely-specific types (InsertObject, Kysely) with the appropriate
Knex types (e.g., Knex, Knex.QueryBuilder) and change sql usages to Knex
query-builder calls inside the PostgresAnalyticsAdapter class and its methods
(search for PostgresAnalyticsAdapter and any methods using sql/InsertObject).
Ensure all query construction, inserts, and type annotations are updated to use
Knex APIs and the adapter still accepts/proxies the same connection/client
instance.
- Around line 105-109: flushTable can lose rows appended during an async flush
because it awaits pending.flush(pending.rows) then clears pending.rows; instead
atomically detach the current batch before awaiting: grab a reference or shallow
copy of pending.rows (e.g., const rowsToFlush = pending.rows), immediately set
pending.rows = [] so subsequent bulkWrite appends go into a fresh array, then
await pending.flush(rowsToFlush); update references to use
pending.flush(rowsToFlush) and ensure this change is applied in the flushTable
method that reads from pendingWrites and calls pending.flush.
---
Nitpick comments:
In `@server/services/derivedFieldsService/helpers.test.ts`:
- Around line 267-316: The test currently uses a broad block-level
eslint-disable/@typescript-eslint/no-explicit-any around multiple expectations;
replace that with narrowly scoped line-level suppressions: remove the
block-level /* eslint-disable ... */ and /* eslint-enable ... */ and add //
eslint-disable-next-line `@typescript-eslint/no-explicit-any` immediately above
each specific line where an any cast is used (the lines calling
parseDerivedFieldSpec(serializeDerivedFieldSpec({... derivationType: ... as
any})) and the three other casts for source with as any/typed casts), keeping
the calls to parseDerivedFieldSpec and serializeDerivedFieldSpec intact and add
short comments explaining why the any is needed for each suppressed line.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 2cf569a1-1827-4f57-bd6d-689ac248c7c3
📒 Files selected for processing (42)
server/api.tsserver/bin/run-worker-or-job.tsserver/condition_evaluator/conditionSet.test.tsserver/condition_evaluator/conditionSet.tsserver/condition_evaluator/leafCondition.tsserver/decs.d.tsserver/graphql/datasources/UserApi.tsserver/graphql/modules/actionStatistics.tsserver/graphql/modules/apiKey.tsserver/graphql/modules/insights.tsserver/graphql/resolvers.tsserver/routes/integration_logos/serveIntegrationLogo.tsserver/routes/integration_logos/serveIntegrationLogoWithBackground.tsserver/routes/policies/PoliciesRoutes.tsserver/routes/reporting/submitReport.tsserver/routes/user_scores/UserScoresRoutes.tsserver/rule_engine/RuleEngine.tsserver/services/aggregationsService/AggregationsService.tsserver/services/analyticsLoggers/ContentApiLogger.tsserver/services/analyticsLoggers/ReportingRuleExecutionLogger.tsserver/services/analyticsLoggers/RoutingRuleExecutionLogger.tsserver/services/analyticsLoggers/RuleExecutionLogger.tsserver/services/analyticsQueries/ItemHistoryQueries.tsserver/services/apiKeyService/apiKeyService.tsserver/services/derivedFieldsService/helpers.test.tsserver/services/derivedFieldsService/helpers.tsserver/services/integrationRegistry/index.tsserver/services/manualReviewToolService/modules/CommentOperations.test.tsserver/services/manualReviewToolService/modules/CommentOperations.tsserver/services/ncmecService/ncmecReporting.tsserver/services/orgAwareSignalExecutionService/signalExecutionService.test.tsserver/services/ruleAnomalyDetectionService/detectRulePassRateAnomaliesJob.tsserver/services/ruleAnomalyDetectionService/getRuleAnomalyDetectionStatistics.test.tsserver/services/ruleAnomalyDetectionService/getRuleAnomalyDetectionStatistics.tsserver/storage/dataWarehouse/ClickhouseAdapter.tsserver/storage/dataWarehouse/IDataWarehouseAnalytics.tsserver/storage/dataWarehouse/PostgresAnalyticsAdapter.tsserver/test/extendExpect.tsserver/utils/errors.tsserver/utils/sql.tsserver/workers_jobs/RefreshMRTDecisionsMaterializedViewJob.tsserver/workers_jobs/RetryFailedNcmecDecisionsJob.ts
💤 Files with no reviewable changes (2)
- server/graphql/modules/actionStatistics.ts
- server/routes/reporting/submitReport.ts
# Conflicts: # server/api.ts # server/graphql/datasources/UserApi.ts # server/services/ncmecService/ncmecReporting.ts
Member
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
Comment on lines
+94
to
99
| // Written by ContentApiLogger. Keep this shape in sync with the | ||
| // `bulkWrite('CONTENT_API_REQUESTS', ...)` call there so the analytics | ||
| // adapter can type-check the row contents at compile time. | ||
| CONTENT_API_REQUESTS: { | ||
| ds: string; | ||
| ts: number; |
Comment on lines
+94
to
+96
| // Written by ContentApiLogger. Keep this shape in sync with the | ||
| // `bulkWrite('CONTENT_API_REQUESTS', ...)` call there so the analytics | ||
| // adapter can type-check the row contents at compile time. |
| typeof SUBQUERY_ALIAS, | ||
| O | ||
| >; | ||
| return outer; |
juanmrad
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
This PR consists of several separate commits so that they would be easier to read by Reviewers. These changes were submitted in a single request to keep related patches together instead of making noise in the PR queue.
Fixes: #198
Tests
Running
npm run lintinserverdirectory should produce no warnings (with an exception for the ones introduced in #349 which was developed in parallel to this patch set).Summary by CodeRabbit
New Features
Bug Fixes
Improvements