Merged
Conversation
Emit `osprey.action_health` (increment) after each action execution completes, tracking whether the action had errors, unexpected errors, and whether it produced any effects. Also emit `osprey.action_error_count` (histogram, 10% sampled) for actions with errors to capture error count distribution. Tags are all bounded: action (~100), had_errors (bool), had_unexpected_errors (bool), had_effects (bool).
One emit per action — no need to sample.
EXBreder
approved these changes
Mar 24, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osprey.action_healthmetric emitted once per action after execution completesosprey.action_error_counthistogram for actions that had errors (10% sampled)action(~100 values),had_errors(bool),had_unexpected_errors(bool),had_effects(bool)Why
We need to quantify what % of Osprey actions execute to completion without failures. Currently there is no per-action health signal — failures are only visible at the UDF level, and "spammy" exceptions are suppressed from existing metrics entirely.
What it measures
had_errors: True/False— whether ANY node errors occurred (includingExpectedUdfException)had_unexpected_errors: True/False— whether non-expected errors occurred (excludesExpectedUdfException)had_effects: True/False— whether the action produced any effects (verdicts, labels, etc.)Key queries
Test plan
ast.parsepasses)./run-tests.sh)