fix(client): declare file size in upload metadata#647
Merged
Conversation
Include file.Size in getParams() so the server receives the declared file size when creating uploads. This allows the server to use the declared size for quota enforcement on in-flight uploads. Regular files (via AddFileFromPath) have their size set from os.Stat. Stdin and archive files naturally stay at 0 (size unknown). Add unit tests for getParams() covering reader-based files, path-based files, and metadata propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Include
file.SizeingetParams()so the server receives the declared file size when creating uploads. This is a prerequisite for server-side quota enforcement on in-flight uploads.Why
The Go client SDK never sent file sizes to the server during upload creation, even when the size was known (regular files via
os.Stat). This prevented the server from using declared sizes for quota enforcement.Changes
plik/file.go— Addparams.Size = file.SizeingetParams()plik/file_test.go— Add 3 tests forgetParams(): reader-based (size=0), path-based (size from os.Stat), and metadata propagationTesting
go vet,go build, andgo test ./plik/...all pass.