Skip to content

Use pthread_attr_setaffinity_np only on glibc#10045

Merged
Axel-Naumann merged 1 commit intoroot-project:masterfrom
BenJarg:musl
Mar 10, 2022
Merged

Use pthread_attr_setaffinity_np only on glibc#10045
Axel-Naumann merged 1 commit intoroot-project:masterfrom
BenJarg:musl

Conversation

@BenJarg
Copy link
Copy Markdown
Contributor

@BenJarg BenJarg commented Mar 4, 2022

This pull request:

Switches ROOT to only using "pthread_attr_setaffinity_np" on glibc, instead of all platforms that aren't MacOS. This function is only available on glibc (see here, so this can currently not be compiled on other libc's for linux, such as musl, or other OS's besides MacOS that don't use glibc.

Changes or fixes:

Fixes compatibility for platforms that aren't MacOS or glibc.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@BenJarg BenJarg marked this pull request as ready for review March 4, 2022 05:34
@Axel-Naumann
Copy link
Copy Markdown
Member

@phsft-bot build!

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann
Copy link
Copy Markdown
Member

And: thanks, @BenJarg !

@Axel-Naumann Axel-Naumann self-assigned this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants