[cling] fix .Class cmd, should accept name by ferdymercury · Pull Request #10350 · root-project/root

ferdymercury · 2022-04-07T13:55:50Z

This Pull request:

Changes or fixes:

.Class <name> command should be the verbose variant of .class <name>, as in CINT, but right now it is ignored.

Checklist:

tested changes locally
updated the docs (if necessary)

phsft-bot · 2022-04-07T13:55:57Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-07T13:57:11Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-07T14:04:20Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-07T14:36:14Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

to match root-project/root#10350

ferdymercury · 2022-04-07T14:52:20Z

Build failed on ROOT-ubuntu16/nortcxxmod. Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build See console output.

Failing tests:

* [projectroot.roottest.cling.operator.roottest_cling_operator_runEqualTest](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/141962/testReport/projectroot.roottest.cling/operator/roottest_cling_operator_runEqualTest/)

* [projectroot.roottest.cling.templateMembers.roottest_cling_templateMembers_runoperatorEqual](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/141962/testReport/projectroot.roottest.cling/templateMembers/roottest_cling_templateMembers_runoperatorEqual/)

* [projectroot.roottest.cling.template.separateDict.roottest_cling_template_separateDict_make](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/141962/testReport/projectroot.roottest.cling.template/separateDict/roottest_cling_template_separateDict_make/)

tests fixed via root-project/roottest#865

phsft-bot · 2022-04-07T15:39:54Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-08T11:07:09Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-08T13:36:57Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

ferdymercury · 2022-04-11T13:03:33Z

Indirectly related Issue: #10140

jalopezg-git

Many thanks for the PR, @ferdymercury! Just some tiny changes to get this in. 🙂

core/base/src/TApplication.cxx

interpreter/cling/lib/MetaProcessor/MetaSema.cpp

interpreter/cling/lib/MetaProcessor/MetaParser.cpp

jalopezg-git · 2022-04-12T09:09:27Z

Assigned @jalopezg-r00t, who I think is the expert and code owner of the interpreter.

Well, one of the experts I would say. 😄

phsft-bot · 2022-04-12T10:21:20Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

jalopezg-git

Many thanks, @ferdymercury! Almost there (just a couple of minor changes)!

Also, before merging, can we rebase and rewrite as 3 commits, as in (i) [core] Minor fix in '.help' command output; (ii) [cling] Minor aesthetic fix in cling '.help' message; and (iii) [cling] Allow '.Class' command to take a class name or so?

interpreter/cling/lib/MetaProcessor/Display.cpp

interpreter/cling/include/cling/MetaProcessor/MetaSema.h

interpreter/cling/lib/MetaProcessor/MetaSema.cpp

phsft-bot · 2022-04-13T10:33:21Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-13T10:33:53Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-13T10:34:32Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

* fix indent as with cling * adapt indent in shortcuts too

fix indentation

* make .Class the verbose equivalent of .class and take into account name passed to .Class. As it was the case in CINT. * merge similar functions into one with a verbose arg

phsft-bot · 2022-04-13T10:47:29Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

ferdymercury · 2022-04-13T10:48:01Z

Also, before merging, can we rebase and rewrite as 3 commits,

Thanks to you for the review. I rebased as suggested :)

(Side note: if you are going ahead with the merge, the corresponding roottest PR root-project/roottest#865 should be merged at the same time, too.)

jalopezg-git

LGTM!

jalopezg-git · 2022-04-13T22:17:58Z

(Side note: if you are going ahead with the merge, the corresponding roottest PR root-project/roottest#865 should be merged at the same time, too.)

Let me just confirm something first. 🙂

@Axel-Naumann, I guess that the experiments are not trying to parse the output of .class / .Class in any case, so the change should be safe?

Axel-Naumann · 2022-04-25T10:58:41Z

the experiments are not trying to parse the output of .class / .Class in any case

Agreed, I'd expect only our tests to notice format changes.

jalopezg-git · 2022-04-25T11:08:30Z

@phsft-bot build

phsft-bot · 2022-04-25T11:08:35Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-04-25T11:57:29Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-04-25T13:57:59Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2022-04-25T15:20:14Z

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

Apply output format changes required for root-project/root#10350.

ferdymercury requested a review from jalopezg-git April 7, 2022 14:10

ferdymercury marked this pull request as ready for review April 7, 2022 14:10

ferdymercury requested a review from Axel-Naumann as a code owner April 7, 2022 14:10

ferdymercury added a commit to root-project/roottest that referenced this pull request Apr 7, 2022

fix test

5054bcd

to match root-project/root#10350

ferdymercury mentioned this pull request Apr 7, 2022

fix class vs Class root-project/roottest#864

Closed

This comment was marked as outdated.

Sign in to view

ferdymercury requested a review from pcanal as a code owner April 7, 2022 15:39

ferdymercury mentioned this pull request Apr 7, 2022

update help message root-project/web#776

Merged

This comment was marked as outdated.

Sign in to view

ferdymercury mentioned this pull request Apr 7, 2022

[cling] fix .Class vs .class command root-project/roottest#865

Merged

This comment was marked as outdated.

Sign in to view

guitargeek assigned jalopezg-git Apr 11, 2022

jalopezg-git suggested changes Apr 12, 2022

View reviewed changes

jalopezg-git added improvement in:Cling and removed in:Core Libraries labels Apr 12, 2022

ferdymercury requested a review from jalopezg-git April 12, 2022 10:22

jalopezg-git suggested changes Apr 13, 2022

View reviewed changes

interpreter/cling/lib/MetaProcessor/Display.cpp Outdated Show resolved Hide resolved

interpreter/cling/include/cling/MetaProcessor/MetaSema.h Outdated Show resolved Hide resolved

interpreter/cling/lib/MetaProcessor/MetaSema.cpp Outdated Show resolved Hide resolved

ferdymercury added 3 commits April 13, 2022 12:44

[core] Minor fix in '.help' command output

259d7a2

* fix indent as with cling * adapt indent in shortcuts too

[cling] Minor aesthetic fix in cling '.help' message

e00fb79

fix indentation

[cling] Allow '.Class' command to take a class name

f2cff67

* make .Class the verbose equivalent of .class and take into account name passed to .Class. As it was the case in CINT. * merge similar functions into one with a verbose arg

ferdymercury force-pushed the Class-cmd branch from a8e8c5f to f2cff67 Compare April 13, 2022 10:47

ferdymercury requested a review from jalopezg-git April 13, 2022 10:48

jalopezg-git approved these changes Apr 13, 2022

View reviewed changes

jalopezg-git pushed a commit to root-project/roottest that referenced this pull request Apr 25, 2022

[cling] fix .Class vs .class command (#865)

574345f

Apply output format changes required for root-project/root#10350.

jalopezg-git merged commit f39eb0e into root-project:master Apr 25, 2022

ferdymercury deleted the Class-cmd branch April 25, 2022 15:51

Conversation

ferdymercury commented Apr 7, 2022

This Pull request:

Changes or fixes:

Checklist:

Uh oh!

phsft-bot commented Apr 7, 2022

Uh oh!

phsft-bot commented Apr 7, 2022

Uh oh!

phsft-bot commented Apr 7, 2022

Uh oh!

phsft-bot commented Apr 7, 2022

Failing tests:

Uh oh!

ferdymercury commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing tests:

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

phsft-bot commented Apr 7, 2022

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

phsft-bot commented Apr 8, 2022

Uh oh!

phsft-bot commented Apr 8, 2022

Failing tests:

Uh oh!

ferdymercury commented Apr 11, 2022

Uh oh!

jalopezg-git left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jalopezg-git commented Apr 12, 2022

Uh oh!

phsft-bot commented Apr 12, 2022

Uh oh!

jalopezg-git left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phsft-bot commented Apr 13, 2022

Uh oh!

phsft-bot commented Apr 13, 2022

Uh oh!

phsft-bot commented Apr 13, 2022

Uh oh!

phsft-bot commented Apr 13, 2022

Uh oh!

ferdymercury commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jalopezg-git left a comment

Choose a reason for hiding this comment

Uh oh!

jalopezg-git commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Axel-Naumann commented Apr 25, 2022

Uh oh!

jalopezg-git commented Apr 25, 2022

Uh oh!

ferdymercury commented Apr 7, 2022 •

edited

Loading

jalopezg-git left a comment •

edited

Loading

ferdymercury commented Apr 13, 2022 •

edited

Loading

jalopezg-git commented Apr 13, 2022 •

edited

Loading