Skip to content

Conversation

@ferdymercury
Copy link
Collaborator

This Pull request:

Changes or fixes:

Supersedes #9616

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury requested a review from pcanal as a code owner March 11, 2024 09:01
@ferdymercury ferdymercury changed the title [skip-ci] [io] Collapse data format details of TFile class. [skip-ci] [io] Collapse data format details of TFile class Mar 11, 2024
@vepadulano
Copy link
Member

vepadulano commented Mar 14, 2024

I believe the changes go in the right direction as discussed in the related PR, thanks a lot @ferdymercury ! Probably we need an explicit approval by @couet that the <details> tag is doing what we expect

@couet
Copy link
Member

couet commented Mar 14, 2024

Hi @vepadulano , I just built the corresponding documentation of this new TFile version. It uses the tag <details> which is not used in ROOT except in a few places in interpreter/llvm-project/clang/www/. This tag allows to hide a part of the doc and make it visible only when clicking on the text given in <summary>. The other new bits are the two \sa which seem fine too.

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @couet for checking and @ferdymercury for the contribution! I believe this looks good

@ferdymercury
Copy link
Collaborator Author

@pcanal how do you like it ?

@ferdymercury
Copy link
Collaborator Author

@couet can you merge? Thanks!

@ferdymercury
Copy link
Collaborator Author

@couet It seems the root-makedoc-master bot is dead, as these changes are not yet visible in the Web? Or does it only rebuild weekly? thanks!

@couet
Copy link
Member

couet commented Apr 11, 2024

@ferdymercury looking at it

@couet
Copy link
Member

couet commented Apr 11, 2024

relaunched

ferdymercury referenced this pull request in ferdymercury/root Nov 25, 2024
Whenever there is an explicit section for Python documentation in a
doxygen page, ensure that is displayed at the top by moving the
generation of the documentation box first in "makeinput.sh". This
section is now called "Python interface" and it is a collapsable box
(open by default) that can be linked to by using the `#python` anchor in
the URL.
ferdymercury added a commit to ferdymercury/root that referenced this pull request Jan 10, 2025
dpiparo pushed a commit that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants