[ntuple] Fix some issues found by Valgrind #16151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream Clang keeps TemplateIdAnnotations around "if they might still be in the token stream." See upstream commit for more details: llvm/llvm-project@6163aa9 (included in Clang 11, in ROOT since the upgrade to LLVM 13) This reasoning doesn't apply when we fully reset the Parser state in ParserStateRAII's destructor, and we expect the swapped out vector of TemplateIdAnnotations to be empty in order to not leak. Fixes root-project#16121
Since RNTuple does not inherit from TObject, it is not tracked by the TFile it came from and must be deleted manually.
Valgrind complains that "Syscall param write(buf) points to uninitialised byte(s)". Fixes commit 0bfd511 ("Implement buffering in RFileSimple")
jblomer
approved these changes
Aug 1, 2024
Test Results 13 files 13 suites 2d 22h 28m 45s ⏱️ Results for commit ea9c9cb. ♻️ This comment has been updated with latest results. |
silverweed
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #16150