Skip to content

[NFC][ntuple] add clarifying comments #16686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jblomer merged 2 commits into from
Oct 15, 2024
Merged

[NFC][ntuple] add clarifying comments #16686

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b778c5
[NFC][ntuple] add clarifying comments
jblomer Oct 15, 2024
9532e4f
[NFC][ntuple] fix typo in code comment
jblomer Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tree/ntuple/v7/test/ntuple_view.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ TEST(RNTuple, ViewFrameworkUse)
auto model = RNTupleModel::Create();
auto ptrPx = model->MakeField<float>("px");
auto ptrPy = model->MakeField<float>("py");
// The trigger pages make a hole in the on-disk layout that is not (purposefully) read
model->MakeField<bool>("trigger");
auto ptrPz = model->MakeField<float>("pz");

Expand Down Expand Up @@ -346,6 +347,8 @@ TEST(RNTuple, ViewFrameworkUse)
}

// Ensure that cluster prefetching and smearing of read requests works
// Note that "nClusterLoaded" is the number of _partial_ clusters preloaded from storage. Because we read
// from the first cluster first px and then py, we'll call two times `LoadCluster()` on the first cluster.
EXPECT_LT(reader->GetDescriptor().GetNClusters(),
reader->GetMetrics().GetCounter("RNTupleReader.RPageSourceFile.nClusterLoaded")->GetValueAsInt());
EXPECT_LT(reader->GetMetrics().GetCounter("RNTupleReader.RPageSourceFile.nReadV")->GetValueAsInt(),
Expand Down