[RDF] preserve order of messages in RDisplay::Print()#17173
Closed
silverweed wants to merge 1 commit intoroot-project:masterfrom
Closed
[RDF] preserve order of messages in RDisplay::Print()#17173silverweed wants to merge 1 commit intoroot-project:masterfrom
silverweed wants to merge 1 commit intoroot-project:masterfrom
Conversation
2 tasks
Member
|
My honest opinion: the previous behaviour was wrong and I sincerely believe that printing all warnings before the actual table just looks better and is less surprising for the user EDIT: The behaviour of printing warnings interleaved with rows of the table is just wrong, I don't think there's anything to discuss here. What I don't know is whether this behaviour was present before #17081, because I never paid attention and because we don't have a test for it. In any case I believe we should not overengineer this very simple feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17081 changed the order or printing in
RDisplay::Print()so that all warnings are now printed before the actual message. This PR restores the original order of printing.