[ntuple] Rename Subfields related methods to be more consistent #17916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enirolf
reviewed
Mar 7, 2025
Contributor
enirolf
left a comment
enirolf
left a comment
There was a problem hiding this comment.
LGTM! Added a few very nitpicky suggestions for your consideration.
Test Results 18 files 18 suites 4d 8h 56m 30s ⏱️ For more details on these failures, see this check. Results for commit 894ae2d. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_ex_subfields
branch
from
681f82b to
894ae2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the same pattern as in
RNTupleModel, the const version ofGetSubFieldsbecomeGetConstSubfieldsand the non-const becomesGetMutableSubfields.Note that the
Fis not capitalized anymore because we decided to keep "subfields" as a single word throughout the whole API.In addition, the
GetRegisteredSubfieldsmethod becomesGetRegisteredSubfieldNamesfor clarity.