Skip to content

Conversation

@siliataider
Copy link
Contributor

@siliataider siliataider commented Mar 27, 2025

This Pull request:

Adds:

This PR updates the ruff formatting workflow to detect and act on the changed lines instead of the whole file.
On failure, the command to run is highlighted so that it can directly be copied and applied locally
image

Note: linting still applies to the full file.

Could be improved once astral-sh/ruff#12800 is implemented
This PR closes #18167

@siliataider siliataider self-assigned this Mar 27, 2025
@github-actions
Copy link

github-actions bot commented Mar 27, 2025

Test Results

    19 files      19 suites   5d 1h 31m 31s ⏱️
 2 737 tests  2 737 ✅ 0 💤 0 ❌
50 195 runs  50 195 ✅ 0 💤 0 ❌

Results for commit b7985d0.

♻️ This comment has been updated with latest results.

@siliataider siliataider force-pushed the ruff-formatting-linting branch 3 times, most recently from ff15879 to e7bae80 Compare March 27, 2025 15:42
@siliataider siliataider marked this pull request as ready for review March 27, 2025 15:47
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@silverweed silverweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left a small comment

@siliataider siliataider force-pushed the ruff-formatting-linting branch from 7009dfb to b7985d0 Compare March 27, 2025 16:37
@siliataider siliataider merged commit 74b0e3c into root-project:master Mar 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci] Apply Ruff Formatting to Changed Lines Only

3 participants