Skip to content

Conversation

@ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented Apr 10, 2025

This Pull request:

Changes or fixes:

std::string(nullptr) is ill-defined. Found out by clang-tidy

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

Test Results

    17 files      17 suites   3d 4h 27m 54s ⏱️
 2 758 tests  2 757 ✅ 0 💤 1 ❌
46 424 runs  46 422 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 1d39b75.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury modified the milestones: 6.36.00, 6.38.00 Apr 22, 2025
@guitargeek guitargeek closed this May 28, 2025
@guitargeek guitargeek reopened this May 28, 2025
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! You missed a convert_to_slash for Windows, but I fixed that up.

@guitargeek guitargeek merged commit 3ffb55c into root-project:master May 29, 2025
20 of 23 checks passed
@ferdymercury ferdymercury deleted the corestrings branch May 29, 2025 13:33
@ferdymercury
Copy link
Collaborator Author

Thanks a lot! You missed a convert_to_slash for Windows, but I fixed that up.

Thanks for finding out! My bad, I should have copy-pasted from your post instead of eye-pasting xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants