[hist,tree] Cleanup IsBaseClass check by using virtual in base and override in derived with empty return #18361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdymercury
commented
Apr 11, 2025
Test Results 18 files 18 suites 3d 7h 40m 31s ⏱️ Results for commit 97bf2e8. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
May 30, 2025
from maciek
change it also in cxx file to avoid inconsistencies with doxygen (potential future) docu
as suggested by silverweed
ferdymercury
commented
May 30, 2025
Contributor
|
Just refreshing the CI results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-6960
Credit for the solution goes to @hansenjo
Checklist: