Don't export CLING_STANDARD_PCH=none in setup scripts
#18378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is set in the ROOT Python setup itself (see 470fddd), and hence we don't need to do it in the setup scripts.
guitargeek
force-pushed
the
cling_standard_pch
branch
from
54794f2 to
40f139b
Compare
Test Results 19 files 19 suites 4d 19h 16m 13s ⏱️ For more details on these failures, see this check. Results for commit 40f139b. |
dpiparo
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is set in the ROOT Python setup itself (see 470fddd), and hence we don't need to do it in the setup scripts.