[core] make static vars constexpr for thread safety v3 #18757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes root-project#18751 All credit goes to vepadulano and guitargeek
2 tasks
guitargeek
reviewed
May 16, 2025
Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
2 tasks
Test Results 19 files 19 suites 3d 10h 24m 8s ⏱️ Results for commit ed1131e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18751
Please squash.
All credit goes to vepadulano and guitargeek
Alternatives to #18753 and #18756
Of course, I could also make a version 4 which just does
lengths {5,5,8}which is even more compact :) and this array did not change in 22 years, so...