Skip to content

RooFit: Fix plotOn normalization for extended PDFs #19656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

RooFit: Fix plotOn normalization for extended PDFs #19656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion roofit/roofitcore/src/RooAbsPdf.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2146,7 +2146,21 @@ RooPlot* RooAbsPdf::plotOn(RooPlot* frame, RooLinkedList& cmdList) const
scaleFactor *= rangeNevt/nExpected ;

} else {
scaleFactor *= frame->getFitRangeNEvt()/nExpected ;
// First, check if the PDF *can* be extended.
if (this->canBeExtended()) {
// If it can, get the expected events.
const double nExp = expectedEvents(frame->getNormVars());
if (nExp > 0) {
// If the prediction is valid, use it for normalization.
scaleFactor *= nExp / nExpected;
} else {
// If prediction is not valid (e.g. 0), fall back to data.
scaleFactor *= frame->getFitRangeNEvt() / nExpected;
}
} else {
// If the PDF can't be extended, just use the data.
scaleFactor *= frame->getFitRangeNEvt() / nExpected;
}
}
} else if (stype==RelativeExpected) {
scaleFactor *= nExpected ;
Expand Down
Loading