[RF] Adding Discrete profiling to RooMinimizer#19685
Merged
guitargeek merged 7 commits intoroot-project:masterfrom Sep 1, 2025
Merged
[RF] Adding Discrete profiling to RooMinimizer#19685guitargeek merged 7 commits intoroot-project:masterfrom
guitargeek merged 7 commits intoroot-project:masterfrom
Conversation
GalinBistrev2
force-pushed
the
fix-root-9
branch
from
d3ee890 to
cebd0bb
Compare
Test Results 19 files 19 suites 3d 10h 7m 39s ⏱️ For more details on these failures, see this check. Results for commit 4506624. ♻️ This comment has been updated with latest results. |
GalinBistrev2
force-pushed
the
fix-root-9
branch
from
291b53e to
3188c49
Compare
guitargeek
reviewed
Aug 30, 2025
guitargeek
approved these changes
Sep 1, 2025
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thank you very much for implementing this and addressing the offline review comments! Looks very good now! Now what is still missing is some tutorial and docs 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds Discrete profiling to RooMinimizer