[tmva][sofie] fix warning due to incorrect else condition in ROperator_BasicBinary#19701
Merged
lmoneta merged 2 commits intoroot-project:masterfrom Aug 21, 2025
Merged
Conversation
Test Results 21 files 21 suites 3d 11h 54m 13s ⏱️ For more details on these failures, see this check. Results for commit 0fe6e0b. ♻️ This comment has been updated with latest results. |
Contributor
|
For the reviewer: The diff is more obvious if you disable white-space changes: https://github.com/root-project/root/pull/19701/files?diff=unified&w=1 |
lmoneta
approved these changes
Aug 21, 2025
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for fixing the warning!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the warnings produced due to the incorrect positioning of the else condition in the Basic Binary Operator of SOFIE.