-
Notifications
You must be signed in to change notification settings - Fork 1.4k
remove old remnants of CINT #19807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove old remnants of CINT #19807
Changes from all commits
d6fcd87
202d9b0
f4072d7
e5a250b
90f36dc
a131cef
610fd0d
072f4f8
a89dc2e
4b54682
bffc210
93350bc
da07032
a340b2d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -385,7 +385,7 @@ TObject *TDirectory::CloneObject(const TObject *obj, Bool_t autoadd /* = kTRUE * | |||||
|
|
||||||
| //create a buffer where the object will be streamed | ||||||
| //We are forced to go via the I/O package (ie TBufferFile). | ||||||
| //Invoking TBufferFile via CINT will automatically load the I/O library | ||||||
| //Invoking TBufferFile via CLING will automatically load the I/O library | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
If I recall correctly, this is the intended casing for Cling. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's in capital letters everywhere in the headers Should I change it everywhere? Or we just leave it hybrid as now? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On the other hand https://github.com/root-project/cling uses @vgvassilev which casing should we use? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Current status in master: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I generally use Cling or cling. |
||||||
| TBuffer *buffer = R__CreateBuffer(); | ||||||
| if (!buffer) { | ||||||
| Fatal("CloneObject","Not able to create a TBuffer!"); | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole paragraph needs to be reviewed, in particular whole the runtime_module mode.