remove old remnants of CINT #19807
remove old remnants of CINT #19807
Conversation
Test Results 20 files 20 suites 4d 2h 40m 39s ⏱️ For more details on these failures, see this check. Results for commit a340b2d. ♻️ This comment has been updated with latest results. |
ferdymercury
force-pushed
the
testcint3
branch
from
ad75ab0 to
a89dc2e
Compare
ferdymercury
changed the title
ferdymercury
requested review from
bellenot,
couet,
dpiparo,
guitargeek,
linev,
lmoneta and
pcanal
as code owners
core/base/inc/GLConstants.h
Outdated
|
|
||
| //*-* This contains the map for those OpenGL package constant the ROOT uses | ||
| //*-* We need the second table since CINT doesn't understand the "define" pre-processor command | ||
| //*-* We need the second table since CLING doesn't understand the "define" pre-processor command |
There was a problem hiding this comment.
Humm .. that sounds like an inaccurate statement about Cling :)
i.e. it is likely the second table is no longer needed ... or maybe it is the first table that is not needed !?
The simplest things to do is:
| //*-* We need the second table since CLING doesn't understand the "define" pre-processor command | |
| //*-* We needed the second table since CING was not able to understand the "define" pre-processor command |
| //create a buffer where the object will be streamed | ||
| //We are forced to go via the I/O package (ie TBufferFile). | ||
| //Invoking TBufferFile via CINT will automatically load the I/O library | ||
| //Invoking TBufferFile via CLING will automatically load the I/O library |
There was a problem hiding this comment.
| //Invoking TBufferFile via CLING will automatically load the I/O library | |
| //Invoking TBufferFile via Cling will automatically load the I/O library |
If I recall correctly, this is the intended casing for Cling.
There was a problem hiding this comment.
It's in capital letters everywhere in the headers
// CLING - the C++ LLVM-based InterpreterG :)
Should I change it everywhere? Or we just leave it hybrid as now?
There was a problem hiding this comment.
On the other hand https://github.com/root-project/cling uses Cling.
@vgvassilev which casing should we use?
There was a problem hiding this comment.
Current status in master:
CLING: 1877 occurrences
Cling: 4324 occurrences
There was a problem hiding this comment.
I generally use Cling or cling.
| # When the interactive ROOT starts, it can automatically load some frequently | ||
| # used includes. However, this introduces several overheads | ||
| # - A long list of CINT and system files will be kept open during the session | ||
| # - A long list of CLING and system files will be kept open during the session |
There was a problem hiding this comment.
This whole paragraph needs to be reviewed, in particular whole the runtime_module mode.
as correctly suggested by pcanal
as suggested by pcanal, rather than defining extra flags
This has been taken over from dpiparos work on root-project#16128
|
@linev As seen in https://github.com/root-project/root/actions/runs/17456882206/job/49572264198?pr=19807 there are some errors in ~20 roottests. See for example https://github.com/ferdymercury/root/blob/testcint3/roottest/root/tree/stl/runmixing.C#L6 |
3 participants
Fixes #10058