[clang-tidy] modernize deprecated headers

[ferdymercury]

https://rocm.docs.amd.com/projects/llvm-project/en/latest/LLVM/clang-tools/html/clang-tidy/checks/modernize/deprecated-headers.html

[github-actions]

Test Results

    20 files      20 suites   3d 19h 59m 29s ⏱️
 3 664 tests  3 663 ✅ 0 💤 1 ❌
71 567 runs  71 561 ✅ 5 💤 1 ❌

For more details on these failures, see this check.

Results for commit 4b49551.

♻️ This comment has been updated with latest results.

[guitargeek]

I think we should keep math.h instead of cmath in the places where we use M_PI (which is from C, and not C++)

[guitargeek]

Thank you very much!

[smuzaffar]

@ferdymercury @guitargeek , while testing latest ROOT master changes we notice massive failure like [a] (fatal error: cannot open file .../stdlib.h) . Could these be due to this change in ROOT ? Looks like rootcling is trying to find the header stdlib.h in the build path which is not available during runtime.

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff4129/48126/addOnTests/hlt_data_PRef/step2.log

fatal error: cannot open file '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../include/c++/12.3.1/stdlib.h': No such file or directory
15-Sep-2025 16:47:10 CEST  Closed file file:RelVal_Raw_PRef_DATA.root
----- Begin Fatal Exception 15-Sep-2025 16:47:10 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L2MuonProducer label='hltL2Muons'
   [2] While initializing meta data for branch: L2MuonTrajectorySeedsToManyL2MuonTrajectorySeedsAssociation_hltL2Muons__HLTPRef.
   [3] Calling edm::TypeWithDict::byName()
   Additional Info:
      [a] Getting TClass for edm::AssociationMap<edm::OneToMany<std::vector<L2MuonTrajectorySeed>,std::vector<L2MuonTrajectorySeed>,unsigned int> >
      [b] Fatal Root Error: @SUB=TInterpreter::AutoParse
Error parsing payload code for class L2MuonTrajectorySeed with content:

#line 1 "DataFormatsMuonSeed_xr dictionary payload"

[ferdymercury]

Could these be due to this change in ROOT ? Looks like rootcling is trying to find the header stdlib.h in the build path which is not available during runtime.

Maybe. Does it also happen with a clean-build from scratch?

[guitargeek]

Thanks for the report @smuzaffar! Can you try with

• [core] Include stdlib.h when running rootcling #19893

?