[RF][HS3] Remove unused constructor#20351
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Nov 8, 2025
Merged
Conversation
Follow up on the previous commit 4c545d7, removing a constructor of an internal class that is now unused.
guitargeek
added
in:RooFit
pr:emergency🚨
Member
This vaguely deserve some investigation as it could uncover missing dependency or a blind spot in the CI. |
pcanal
approved these changes
Nov 8, 2025
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
LGTM (beside the mystery of how it pass the CI before :( )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on the previous commit 4c545d7, removing a constructor of an internal class that is now unused.
Emergency PR because this fixes the CI failures on the Debians with
dev=ON.What is surprising is that the errors didn't appear in the PR that made the constructor unused:
https://github.com/root-project/root/pull/20276/checks
Maybe it's because of the incremental builds, but I'm not sure.