Skip to content

Conversation

@bellenot
Copy link
Member

This PR fixes #20312

  • In TCling::CreateListOfBaseClasses, ignore the std::_Complex_base base class
  • Since the order of execution of function arguments are not guarantees, don't pass TRandom3 methods as function arguments
    This fixes the execreadcomplex.C and execwritecomplex.C macros
  • Code formatting

This PR fixes root-project#20312
- In TCling::CreateListOfBaseClasses, ignore the `std::_Complex_base` base class
- Since the order of execution of function arguments are not guarantees, don't pass TRandom3 methods as function arguments
  This fixes the `execreadcomplex.C` and `execwritecomplex.C` macros
- Code formatting
@bellenot bellenot requested a review from pcanal November 24, 2025 15:01
@bellenot bellenot self-assigned this Nov 24, 2025
@bellenot bellenot requested a review from dpiparo as a code owner November 24, 2025 15:01
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci.

@bellenot
Copy link
Member Author

Merci.

Merci à toi ! 😃

@github-actions
Copy link

Test Results

    22 files      22 suites   3d 21h 44m 58s ⏱️
 3 777 tests  3 776 ✅ 0 💤 1 ❌
81 190 runs  81 189 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit f6d6951.

@bellenot
Copy link
Member Author

Errors are unrelated. Merging.

@bellenot bellenot merged commit ec01d4e into root-project:master Nov 25, 2025
28 of 30 checks passed
@bellenot bellenot deleted the fix-std-complex-windows branch November 25, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for std::complex on Windows

2 participants