[CPyCppyy] Correctly handle static method calls via derived instance #20496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
guitargeek
force-pushed
the
issue-20463
branch
2 times, most recently
from
2e931ff to
d988f34
Compare
dpiparo
approved these changes
Nov 24, 2025
Member
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
Fine for me if all tests pass.
The mechanism to strip away the "self" argument from the call to a static method checks the type of "self", matching the exact type. However, it should also remove the "self" if it is an instance of a derived type, because in C++ it is also possible to call static methods via instances of derived types. A unit test was also added. Closes root-project#20463.
guitargeek
force-pushed
the
issue-20463
branch
from
d988f34 to
027aa21
Compare
Contributor
Author
|
Tests passed (just fixed typo in the commit message with recent push) |
guitargeek
changed the title
Contributor
|
I'd recommend leaving |
Contributor
Author
|
Good point, I was thinking that too before. But the equality shortcut check is already done in the implementation of And I don't think the overhead of the function call matters here, or does it? |
Contributor
|
No, you're quite right, that's good enough. It's also a better place for the short-cut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism to strip away the "self" argument from the call to a static method checks the type of "self", matching the exact type.
However, it should also remove the "self" if it is an instance of a derived type, because in C++ it is also possible to call static methods via instances of derived types.
A unit test was also added.
Closes #20463.