Skip to content

[tmva][pymva] Exercise removal of deprecated TMVA PyKeras method #20577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guitargeek wants to merge 3 commits into from
Closed

[tmva][pymva] Exercise removal of deprecated TMVA PyKeras method #20577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
918ad39
[tmva][pymva] Deprecate the `PyKeras` method
guitargeek Nov 30, 2025
f131693
[ci] Enable `tmva-pymva` again
guitargeek Nov 30, 2025
8627576
[tmva][pymva] Remove PyKeras method to see effect on CI
guitargeek Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/root-ci-config/buildconfig/global.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ testing=ON
tmva-cpu=ON
tmva-gpu=OFF
tmva-cudnn=OFF
tmva-pymva=OFF
tmva-pymva=ON
tmva-rmva=OFF
tmva-sofie=OFF
tmva=ON
Expand Down
1 change: 1 addition & 0 deletions README/ReleaseNotes/v640/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ The following people have contributed to this new version:
* Comparing C++ `nullptr` objects with `None` in Python now raises a `TypeError`, as announced in the ROOT 6.38 release notes. Use truth-value checks like `if not x` or `x is None` instead.
* The `TGLIncludes.h` and `TGLWSIncludes.h` that were deprecated in ROOT 6.38 and scheduled for removal are gone now. Please include your required headers like `<GL/gl.h>` or `<GL/glu.h>` directly.
* The GLEW headers (`GL/eglew.h`, `GL/glew.h`, `GL/glxew.h`, and `GL/wglew.h`) that were installed when building ROOT with `builtin_glew=ON` are no longer installed. This is done because ROOT is moving away from GLEW for loading OpenGL extensions.
* The TMVA `PyKeras` method is deprecated. It was broken by the API changes in Keras 3, released in November 2023 and part of TensorFlow 2.16 or newer. The `PyKeras` method will be removed in ROOT 6.42 (unless an updated implementation for Keras 3 that matches usage, performance and stability requirements will be found unexpectedly).

## Build System

Expand Down
2 changes: 0 additions & 2 deletions tmva/pymva/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,12 @@ ROOT_STANDARD_LIBRARY_PACKAGE(PyMVA
HEADERS
TMVA/MethodPyAdaBoost.h
TMVA/MethodPyGTB.h
TMVA/MethodPyKeras.h
TMVA/MethodPyRandomForest.h
TMVA/MethodPyTorch.h
TMVA/PyMethodBase.h
SOURCES
src/MethodPyAdaBoost.cxx
src/MethodPyGTB.cxx
src/MethodPyKeras.cxx
src/MethodPyRandomForest.cxx
src/MethodPyTorch.cxx
src/PyMethodBase.cxx
Expand Down
1 change: 0 additions & 1 deletion tmva/pymva/inc/LinkDef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@
#pragma link C++ class TMVA::MethodPyRandomForest+;
#pragma link C++ class TMVA::MethodPyAdaBoost+;
#pragma link C++ class TMVA::MethodPyGTB+;
#pragma link C++ class TMVA::MethodPyKeras+;
#pragma link C++ class TMVA::MethodPyTorch+;
#endif
118 changes: 0 additions & 118 deletions tmva/pymva/inc/TMVA/MethodPyKeras.h
View file
Open in desktop

This file was deleted.

Loading
Loading