[ntuple] Propagate type aliases from item fields #20623
Conversation
jblomer
force-pushed
the
ntuple-propagate-type-alias
branch
from
3ec064d to
934d6af
Compare
The variant field, the tuple field, and the pair field all use approximately the same GetTypeList() private static method. Factor this out in a single method in an anonymous namespace.
When constructing compound types from item fields, propagate alias types from the item fields to the parent field. This is already done globally in RFieldBase::Create() because the entire type name is compared to the unresolved type name. However, the type alias propagation was missing when a field is directly constructed with an item field.
Test Results 22 files 22 suites 3d 23h 39m 39s ⏱️ Results for commit 934d6af. |
I'm not fully sure. The framework's EDM wraps everything in I don't know if NanoAOD stores anything in e.g. We set the |
| } | ||
|
|
||
| std::string BuildSetTypeName(ROOT::RSetField::ESetType setType, const ROOT::RFieldBase &innerField) | ||
| std::string GetTypeList(std::span<std::unique_ptr<ROOT::RFieldBase>> itemFields, bool useTypeAliases) |
There was a problem hiding this comment.
Consider adding a short summary of the behavior (Intend of the use of the result, reach of the list).
3 participants
This should be the last piece to fix #20282. In particular, it is necessary to fix
[U]Long64_ttemplate arguments where the type is not wrapped in a class. I.e. without this fixAnother PR with the corresponding test will follow.
@makortel Please let me know if you need this backported to 6.36. This depends on whether your top-level branches are all wrapped in a class or if you have STL collections directly as top-level branches.