[RF] Don't randomize number of events when creating Asimov from RooSimultaneous #20625
+59
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
changed the title
ferdymercury
reviewed
Dec 3, 2025
When this data member is used, it is completely overwritten, so why have it and fill it in the constructor.
The procedure can be coded up in a clearer way, without a `frashThresh` array.
Closes JIRA ticket https://its.cern.ch/jira/browse/ROOT-7499 Implement also a unit test, inspired by the reproducer posted on JIRA.
Test Results 22 files 22 suites 3d 18h 25m 30s ⏱️ Results for commit 8afa3e7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes JIRA ticket https://its.cern.ch/jira/browse/ROOT-7499
Implement also a unit test, inspired by the reproducer posted on JIRA.
The first two commits are small refactors to avoid dead code and make the code simpler.
FYI, @will-cern.