Skip to content

[RF] Fix RooLognormal analytical integral for xMin < zero #20675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 1 commit into from
Dec 11, 2025
Merged

[RF] Fix RooLognormal analytical integral for xMin < zero #20675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions roofit/roofit/src/RooLognormal.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ The parameterization here is physics driven and differs from the ROOT::Math::log

#include "RooLognormal.h"
#include "RooRandom.h"
#include "RooMath.h"
#include "RooHelpers.h"
#include "RooBatchCompute.h"

Expand Down Expand Up @@ -104,9 +103,11 @@ double RooLognormal::analyticalIntegral(Int_t /*code*/, const char *rangeName) c
static const double root2 = std::sqrt(2.);

double ln_k = std::abs(_useStandardParametrization ? k : std::log(k));
double scaledMin = _useStandardParametrization ? std::log(x.min(rangeName)) - m0 : std::log(x.min(rangeName) / m0);
double scaledMax = _useStandardParametrization ? std::log(x.max(rangeName)) - m0 : std::log(x.max(rangeName) / m0);
return 0.5 * (RooMath::erf(scaledMax / (root2 * ln_k)) - RooMath::erf(scaledMin / (root2 * ln_k)));
const double xMin = std::max(x.min(rangeName), 0.);
const double xMax = x.max(rangeName);
double scaledMax = _useStandardParametrization ? std::log(xMax) - m0 : std::log(xMax / m0);
double scaledMin = _useStandardParametrization ? std::log(xMin) - m0 : std::log(xMin / m0);
return 0.5 * (std::erf(scaledMax / (root2 * ln_k)) - std::erf(scaledMin / (root2 * ln_k)));
}

////////////////////////////////////////////////////////////////////////////////
Expand Down
Loading