[v638] Check for existence of xml node before reading it#20867
Merged
guitargeek merged 1 commit intoroot-project:v6-38-00-patchesfrom Jan 13, 2026
Merged
[v638] Check for existence of xml node before reading it#20867guitargeek merged 1 commit intoroot-project:v6-38-00-patchesfrom
guitargeek merged 1 commit intoroot-project:v6-38-00-patchesfrom
Conversation
This avoids breaking the reading of pre-existing TMVA weight files that have been written without this tag. Add a regression test with a weights file that does not yet contain this tag. (cherry picked from commit db2244d)
2 tasks
guitargeek
merged commit 1f92ddb
into
root-project:v6-38-00-patches
28 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids breaking the reading of pre-existing TMVA weight files that have been written without this tag.
Add a regression test with a weights file that does not yet contain this tag.
(cherry picked from commit db2244d)
Backport of: