[CMake] Don't use find_package(ROOT) in tutorials/ subdirectory#20996
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Jan 23, 2026
Merged
[CMake] Don't use find_package(ROOT) in tutorials/ subdirectory#20996guitargeek merged 1 commit intoroot-project:masterfrom
tutorials/ subdirectory#20996guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
As Sergey said in the comment in `tutorials/CMakeLists.txt`, this tutorials project stopped working standalone. But, it still uses `find_package(ROOT)` to find ROOT, even though it's not installed yet as we are building ROOT itself at the same time. This should better not be done. This commit suggest to remove it, and also replaces the variables defined by `find_package(ROOT)` with the built time variables. This follows up on 9d2dc6e c21bc3f, and 458803e, which did the same for the `test/` and `roottest/` subdirectories.
Test Results 22 files 22 suites 3d 11h 12m 43s ⏱️ Results for commit 0eb4990. |
hageboeck
approved these changes
Jan 23, 2026
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
LGTM, but maybe make the path to root.exe explicit.
Contributor
Author
|
Thanks for the review! Your comments are perfectly valid and I will consider them, but as they are independent from this PR I'll do that in a followup PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Sergey said in the comment in
tutorials/CMakeLists.txt, this tutorials project stopped working standalone. But, it still usesfind_package(ROOT)to find ROOT, even though it's not installed yet as we are building ROOT itself at the same time.This should better not be done. This commit suggest to remove it, and also replaces the variables defined by
find_package(ROOT)with the built time variables.This follows up on 9d2dc6e c21bc3f, and 458803e, which did the same for the
test/androottest/subdirectories.