[core] Follow symlinks in TROOT::GetSharedLibDir()
#21033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @smuzaffar, I think this should fix the problem. Can you maybe verify that before we merge this PR? Thanks! |
pcanal
reviewed
Jan 26, 2026
pcanal
approved these changes
Jan 26, 2026
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
LGTM (beside detail on error handling)
guitargeek
force-pushed
the
issue-21031
branch
from
0e6ea6d to
b091755
Compare
Test Results 22 files 22 suites 3d 9h 59m 26s ⏱️ Results for commit 5ae8259. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Jan 26, 2026
Contributor
|
@guitargeek , cmssw tests are running via cms-sw#229 now |
The idea is to find the actual ROOT install directory, so we have to follow symlinks. The `info->dlpi_name` doesn't do that, so we need to do that ourselves with `fs::canonical()`. Closes root-project#21031.
guitargeek
force-pushed
the
issue-21031
branch
from
b091755 to
5ae8259
Compare
Contributor
|
@guitargeek , cmssw tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to find the actual ROOT install directory, so we have to follow symlinks. The
info->dlpi_namedoesn't do that (I have verified that locally), so we need to do that ourselves withfs::canonical().Closes #21031.