[roottest] Use RPATH instead of setting LD_LIBRARY_PATH#21083
Closed
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Closed
[roottest] Use RPATH instead of setting LD_LIBRARY_PATH#21083guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
This avoids overwriting the LD_LIBRARY_PATH from the build environment. Closes root-project#21076.
Test Results 22 files 22 suites 3d 14h 20m 23s ⏱️ For more details on these failures, see this check. Results for commit 8b04bd0. |
pcanal
reviewed
Jan 30, 2026
| # variables in the build environment. | ||
| if(NOT MSVC) | ||
| if(APPLE) | ||
| set(new_rpath "@loader_path/librntuplestltest") |
Member
There was a problem hiding this comment.
This seems ineffective/incomplete (lead to test failure on mac builds - there does not seem to be a trace of the subdirectory name in the output).
Contributor
Author
|
Superseded by #21097 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids overwriting the LD_LIBRARY_PATH from the build environment.
Closes #21076.