Prepare roottest for ROOT 7's ownership model #21225
Open
+26
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was relying on implicit ownership to transfer a histogram from python to C++, so now the histogram is appended explicitly.
The tutorial was running code that didn't directly reference the histogram, so it fails when implicit ownership is off.
Test Results 22 files 22 suites 3d 15h 9m 47s ⏱️ Results for commit f39f216. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In essence, add
histo.SetDirectory(xxx)to all places where a histogram should show up in a TDirectory independent of whether it has been registered automatically.