[hist] Implement RHistStats::Taint() and RHist{,Engine}::SetBinContent#21355
Merged
hahnjo merged 5 commits intoroot-project:masterfrom Mar 25, 2026
Merged
[hist] Implement RHistStats::Taint() and RHist{,Engine}::SetBinContent#21355hahnjo merged 5 commits intoroot-project:masterfrom
RHistStats::Taint() and RHist{,Engine}::SetBinContent#21355hahnjo merged 5 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 7h 6m 15s ⏱️ For more details on these failures, see this check. Results for commit 1c7a6ce. ♻️ This comment has been updated with latest results. |
Member
Author
|
gentle ping :-) |
If a dimension is disabled, it should not be possible to retrieve its quantities.
hageboeck
approved these changes
Mar 24, 2026
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
LGTM, but the logic_error could explain a bit more how to avoid tainting.
This will be used to taint the global statistics if the user modifies bin contents explicitly or slices histograms without preserving all entries, for example. The implementation choice is to allow modifications without extra checks / performance penalty, and throw on read access.
This needs one indirection to construct the std::array of indices with the right (number of) elements. Also remove Internal::SetBinContent that is not needed anymore.
It will taint the histogram statistics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed during the last PPP, calling
RHist::SetBinContentwill taint the global histogram statistics.