[Python] Add missing numpy int8/uint8 support in AsRVec#21374
Merged
siliataider merged 2 commits intoroot-project:masterfrom Feb 25, 2026
Merged
[Python] Add missing numpy int8/uint8 support in AsRVec#21374siliataider merged 2 commits intoroot-project:masterfrom
siliataider merged 2 commits intoroot-project:masterfrom
Conversation
siliataider
force-pushed
the
numpy_conv
branch
from
5901fc6 to
871eb6e
Compare
vepadulano
approved these changes
Feb 25, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thank you! LGTM once tests are green.
siliataider
force-pushed
the
numpy_conv
branch
from
871eb6e to
fc1d800
Compare
siliataider
force-pushed
the
numpy_conv
branch
from
fc1d800 to
dfd05d8
Compare
Test Results 22 files 22 suites 3d 4h 36m 55s ⏱️ For more details on these failures, see this check. Results for commit dfd05d8. |
Member
|
/backport to 6.38 |
Member
|
Let me re-iterate, please /backport to 6.38 |
|
This PR has been backported to branch 6.38: #21381 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This PR adds the missing
numpy.int8(i1) andnumpy.uint8(u1) pythonizations inAsRVec, an issue (partially) reported and described in this ROOT forum post:https://root-forum.cern.ch/t/missing-numpy-uint8-pythonisation-in-setbranchaddress-in-root-6-38
Now:
u1maps tounsigned charand adopts memory like all other numeric types.i1maps tosigned charbut must be copied rather than adopted because the the ptr+size constructor forRVec<signed char>is not exposed.Checklist:
This PR fixes # https://root-forum.cern.ch/t/wrong-conversion-of-bool-array-to-numpy-array/64714?u=siliataider
Fixes #21379