Fix argument passing conventions in THbookFile#21407
Merged
hageboeck merged 2 commits intoroot-project:masterfrom Feb 28, 2026
Merged
Fix argument passing conventions in THbookFile#21407hageboeck merged 2 commits intoroot-project:masterfrom
hageboeck merged 2 commits intoroot-project:masterfrom
Conversation
hageboeck
force-pushed
the
fix_h2root
branch
from
0aca4e5 to
5d75325
Compare
When variable-length strings are passed into functions compiled by gfortran, the lengths of the strings have to be passed at the end of the argument list as size_t. When using gcc <= 7 or clang (where the __GNUC__ macro might return unpredictable values), we were putting int on the C side, which got interpreted as size_t on the fortran side.
hageboeck
force-pushed
the
fix_h2root
branch
from
5d75325 to
c2c1044
Compare
hageboeck
force-pushed
the
fix_h2root
branch
from
c2c1044 to
09ad756
Compare
Collaborator
|
Side note, after incorporating these changes, it still fails on alma10 without -O0, see https://github.com/root-project/root/actions/runs/22499554944/job/65182799794?pr=20538 (tracked at #19329) |
dpiparo
approved these changes
Feb 27, 2026
Test Results 22 files 22 suites 3d 6h 27m 58s ⏱️ Results for commit 09ad756. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in
#21404 (comment)
Update argument passing also in THbookFile.