[tmva][sofie] Fix NonZero to define max output shape value in the Session constructor#21458
Merged
lmoneta merged 1 commit intoroot-project:masterfrom Mar 3, 2026
Merged
Conversation
lmoneta
changed the title
guitargeek
approved these changes
Mar 3, 2026
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thank you very much! Works for me 👍
guitargeek
reviewed
Mar 3, 2026
Test Results 22 files 22 suites 3d 4h 34m 44s ⏱️ For more details on these failures, see this check. Results for commit 0759a34. |
…n ctor The maximum value of the output shape (the number of non zero elements) does not need to be defined as Session data member but can be defined in the Session constructor. This requires adding a new function in ROperator, GenerateSessionCtorCode to add the code defining the max value. We cannot use GenerateInitCode, because this is used for code that is executed after having allocated the dynamic tensors.
lmoneta
force-pushed
the
tmva_sofie_fix_nonzero
branch
from
0759a34 to
16660b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum value of the output shape (the number of non zero elements) does not need to be defined as Session data member but can be defined in the Session constructor. This requires adding a new function in ROperator, GenerateSessionCtorCode to add the code defining the max value. We cannot use GenerateInitCode, because this is used for code that is executed after having allocated the dynamic tensors.
This Pull request replaces #21452