[tmva][sofie] Remove ConvertShapeToString and ConvertDynamicShapeToLength#21509
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 10, 2026
Merged
[tmva][sofie] Remove ConvertShapeToString and ConvertDynamicShapeToLength#21509guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 5h 5m 1s ⏱️ Results for commit 8d1e761. ♻️ This comment has been updated with latest results. |
lmoneta
reviewed
Mar 9, 2026
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
I agree it is better to have only one signature, and thank you very much Jonas for improving on this.
However, I think it should be better to drop "ConvertDynamicShapeToKength" and keep "ConvertDimShapeToString", which is much more used and more consistent with other functions (e.g. ConvertShapeToDim).
Also a tensor with a shape represented as a vector can have fixed dimensions. So it is more correct semantically.
Remove the redundant `ConvertShapeToString` and `ConvertDynamicShapeToLength` functions, because there are alternatives with more expressive names: `ConvertDimShapeToString` and `ConvertDimShapeToLength`. Having the same functions with different names is just confusing.
guitargeek
changed the title
Contributor
Author
|
Very well! I have updated the PR to keep the more expressive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the redundant
ConvertShapeToStringandConvertDynamicShapeToLengthfunctions, because there are alternativeswith more expressive names:
ConvertDimShapeToStringandConvertDimShapeToLength. Having the same functions with differentnames is just confusing.