ACLiC: Use NUL or distinct temporary file on Windows.#21639
Merged
pcanal merged 1 commit intoroot-project:masterfrom Mar 19, 2026
Merged
ACLiC: Use NUL or distinct temporary file on Windows.#21639pcanal merged 1 commit intoroot-project:masterfrom
pcanal merged 1 commit intoroot-project:masterfrom
Conversation
Previously the output of ACLiC dependency generation stage was use the same name (in different directory) in all case on Windows to suppress the output of 'rmkdepend'. This commit changes the behavior by using the null device also on Windows (which fall backs if we can't determine the shell - but the fall back is now using a unique name).: Determine the null device based on the shell in use. COMSPEC unset or pointing to cmd.exe -> NUL COMSPEC pointing to powershell -> $null Anything else (e.g. bash/sh on Windows) -> `depfilename`.stderr.tmp
Test Results 21 files 21 suites 3d 2h 2m 12s ⏱️ Results for commit 83a4a91. |
Member
Author
|
The ubuntu failure is unrelated (missing package on the CI node) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the output of ACLiC dependency generation stage was use the same name (in different directory) in all case on Windows to suppress the output of 'rmkdepend'. This commit changes the behavior by using the null device also on Windows (which fall backs if we can't determine the shell - but the fall back is now using a unique name).:
Determine the null device based on the shell in use.
COMSPEC unset or pointing to cmd.exe -> NUL
COMSPEC pointing to powershell -> $null
Anything else (e.g. bash/sh on Windows) ->
depfilename.stderr.tmp