[gui] let use some classes in batch mode#21907
Open
linev wants to merge 3 commits intoroot-project:masterfrom
Open
[gui] let use some classes in batch mode#21907linev wants to merge 3 commits intoroot-project:masterfrom
linev wants to merge 3 commits intoroot-project:masterfrom
Conversation
In batch mode fNormGC is 0 and therefore not equal to the GetDefaultGC(). But in destructor fHasOwnFont used to delete gc object which not allocated by TGLabel
In any situation such created TGGC instance should have proper ref count value
In batch real pixmap manipulation is not possible. But all instances of TGPicture are created. In normal mode they are "hidden", but in batch one can return pointer on the picture to suppress many errors printout in the TG.. classes By the way - by the first call of `TGPicturePool::GetPicture()` also dummy ` TGPicture` is returned
2 tasks
Test Results 22 files 22 suites 3d 8h 20m 38s ⏱️ For more details on these failures, see this check. Results for commit fb1d269. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TGPictureobjects in batch. Even if pixmap is empty - return pointer on existing object to suppress warnings in theTG...constructorsTGLabelsetfHasOwnFontflag only when really newTGGCobject is allocated. Otherwise in destructor TGLabel tries to delete instance which is not owned. Appears in batch modeThis PR will help to run GUI tests in batch mode like prepared in #21882