Increase the number of includes in countIncludePaths.C#21932
Merged
guitargeek merged 2 commits intoroot-project:masterfrom Apr 17, 2026
Merged
Increase the number of includes in countIncludePaths.C#21932guitargeek merged 2 commits intoroot-project:masterfrom
countIncludePaths.C#21932guitargeek merged 2 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 4h 6m 21s ⏱️ Results for commit 4f83fbc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, in LCG stacks we stopped using builtins in ROOT and this test stopped working, probably because there are more include paths now.
These are the list of includes that the macro reports:
We get 13, but it's true we can remove the one from
vc, so I'm requesting 12. The ones forpcre2,xxHash,tbbandjsonmpp(nlohmann-json) come from dependencies; at leastpcre2andxxHashmay not have been there before. The ones fromVcandvdtare what we have inROOT_INCLUDE_PATHbefore running the tests, I think the rest it is not us who are setting them. I'm not sure if a thorough investigation is worth it for this test.