[webcanvas] add specified file extension when call "Save as" dialog#21935
Merged
linev merged 3 commits intoroot-project:masterfrom Apr 17, 2026
Merged
[webcanvas] add specified file extension when call "Save as" dialog#21935linev merged 3 commits intoroot-project:masterfrom
linev merged 3 commits intoroot-project:masterfrom
Conversation
Appending missing extension when typed file name does not contain file extension
1. Correctly draw axis ticks when `fNdivisions` is negative 2. Fix - properly detect file format when store canvas image
This was referenced Apr 16, 2026
Test Results 22 files 22 suites 3d 3h 25m 3s ⏱️ Results for commit 659b9b4. ♻️ This comment has been updated with latest results. |
Now negative fNdiv handled properly, therefore output changed a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When press "Ok" button, check if typed file name has specified extension.
If not - add it in any case.
Also fix problem in JSROOT when file have multiple extensions like "file.a.png".
JSROOT was using `filename.indexOf(".") to detect file extension.
Plus few other fixes.
Fixes #21933